Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding day length factor switch #1161

Merged
merged 7 commits into from
Apr 26, 2024
Merged

Adding day length factor switch #1161

merged 7 commits into from
Apr 26, 2024

Commits on Feb 14, 2024

  1. adding user switch for turning on and off daylength factor scalingfor… 

    … photosynthesis parameters
    @jenniferholm
    jenniferholm committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2fa6353 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. refactoring the daylength factor application 

    This reduces code duplication somewhat by updating a local
value of the daylength factor based on the switch value.  I also
changed the switch to be zero for off and one for on to utilize
the existing itrue/ifalse constants.
    @glemieux
    glemieux committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4b26a88 View commit details
    Browse the repository at this point in the history

  2. add check to verify that the use supplied an appropriate parameter value 

    for daylength switch
    @glemieux
    glemieux committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    02af1cb View commit details
    Browse the repository at this point in the history

  3. add code comment about daylength factor

    @glemieux
    glemieux committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    482efe2 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. remove day length factor input to atkin subroutine

    @glemieux
    glemieux committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    0633d1e View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. trivial merge resolution

    @rgknox
    rgknox committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    668fabd View commit details
    Browse the repository at this point in the history

  2. reverting to parameter file from main, because daylength factor switc… 

    …h was already in there
    @rgknox
    rgknox committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a9b5230 View commit details
    Browse the repository at this point in the history