Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hydraulic failure mortality for leafless plants #1130

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

mpaiao
Copy link
Contributor

@mpaiao mpaiao commented Dec 8, 2023

Description:

These changes are mostly to be on the safe side. Hydraulic failure mortality is triggered when btran is too low (non-hydro mode) or when hydraulic conductivity is diminished (hydro mode). This pull request adds a check to see if the PFT is deciduous and is completely leafless. In these cases, hydraulic failure is forced to zero.

  1. This change impacts both drought-deciduous and cold-deciduous PFTs.
  2. In the future, we may want to coordinate hydraulic failure with phenology, to ensure that deciduous plants abscise leaves instead of dying when under high risk of hydraulic failure.

Collaborators:

Expectation of Answer Changes:

This may have minimal effect under severely dry conditions.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

… they are leafless.

Change in the hydraulic failure mortality function, to prevent plants that have no leaves
to die of hydraulic failure.
1. This change impacts both drought-deciduous and cold-deciduous PFTs, as the idea is that
   leafless plants cannot cavitate.
2. This may be an overly cautious step. It all depends on how btran is defined when cohorts
   lose all leaves. This should also be unlikely when FATES-hydro is on.
@glemieux glemieux added check Related to internal checks of any type (e.g. variable state) mortality Pertaining to changes to plant mortality labels Dec 8, 2023
( prt_params%stress_decid(cohort_in%pft) == ihard_stress_decid .or. & ! Drought deciduous
prt_params%stress_decid(cohort_in%pft) == isemi_stress_decid .or. & ! Semi-deciduous
prt_params%season_decid(cohort_in%pft) == itrue ) .and. & ! Cold deciduous
( cohort_in%status_coh == leaves_off ) ! ! Fully abscised
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I started to muse about what guidance we could offer in the future if we ever enable a long window of time for leaf drop, but that would be a full discussion and could not really be encapsulated in a couple of comments here.

Copy link
Contributor

@ZacharyRobbins ZacharyRobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this code looks good. If my review of the btran functions is correct, I believe the explicit case this prevents is in non-hydro mode. When soil moisture is sufficiently low to trigger btran-hydraulic failure mortality in a plant that is not transpiring. I agree that is unlikely this would change much when FATES hydro is on., though I don't think its impossible for PLC to go up under leafless conditions.

I guess my only larger science concern is that plants lose water even in the absence of leaves, and hydraulic failure would still be possible through stem permeabilty and loss through roots. Given the approximation that is btran, I don't think its unreasonable to make exception for this (as one would assume in a broad sense leaf loss greatly lowers the risk of HF). But I wanted to voice this concern, particularly that with 1. being that leafless plants cannot experience cavitation, which I don't think is explicitly true.

Wolfe, B. T., Sperry, J. S., & Kursar, T. A. (2016). Does leaf shedding protect stems from cavitation during seasonal droughts? A test of the hydraulic fuse hypothesis. New Phytologist, 212(4), 1007-1018.

Thank you.

@mpaiao
Copy link
Contributor Author

mpaiao commented Jan 18, 2024

Thanks for the feedback @ZacharyRobbins! I'm not very familiar with FATES-Hydro, but if the current FATES-Hydro implementation allows for plants to continue losing water when they are leafless, then we definitely don't want this change, at least when FATES-Hydro is on. Let me know and I can update/close the PR.

@rosiealice
Copy link
Contributor

So the loss of water from leafless plants is a big issue for frozen soils, which all else being equal, dehydrate the plants via the roots, leading to massive hydraulic failure.

To prevent this, in Marius Lambert's work, the (minimum) stomatal conductance and the root conductivity needed to be dialled down (a lot) as a function of hardening (from his earlier paper).

Unfortunately this didn't make it to the trunk (Marius started working on river DOC immediately after finishing his thesis), and we are writing a proposal to follow it up.

But the lessons learned remain valid, and I think maybe transferable to the super dry soil conditions also where we know that Piñon pines become hydraulically isolated when swp <-3Mpa, from all of the work in NM etc.

  • If we turn this option on in fates hydro it might help stop things dying in the off season (if that is desired) but there would be a potentially big pulse of mortality when the leaves came back on... we could prevent that by stopping the leaves coming in if the plc was high, but it would probably be better to stop the (bulk of the) dehydration process in the first place?

@mpaiao
Copy link
Contributor Author

mpaiao commented Jan 23, 2024

Thanks for the feedback @rosiealice, and good to know that there is some more mechanistic approach to prevent the mortality. So maybe for now the best option is to implement my original suggestion only when FATES-Hydro is turned off, and note that in the future we will incorporate Marius' work?

@ZacharyRobbins
Copy link
Contributor

I think that makes sense @mpaiao .

@glemieux
Copy link
Contributor

@JessicaNeedham and @mpaiao, in deconflicting main against this PR branch, I was unsure how to reconcile the update from #1115. The current code on main has the following:

else
if( ( btran_ft(cohort_in%pft) <= hf_sm_threshold ) .and. &
( ( minval(bc_in%t_soisno_sl) - tfrz ) > soil_tfrz_thresh ) ) then
hmort = EDPftvarcon_inst%mort_scalar_hydrfailure(cohort_in%pft)

If we have time, we can discuss together at the fates software meeting today.

@mpaiao
Copy link
Contributor Author

mpaiao commented Jan 29, 2024

@glemieux Thanks for pointing out the conflict. Perhaps the simplest way would be to rewrite the if block as the following:

          ! When FATES-Hydro is off, hydraulic failure mortality occurs only when btran
          ! falls below a threshold, soils are not frozen and plants have leaves.
          if ( ( .not. is_decid_dormant ) .and. & 
               ( btran_ft(cohort_in%pft) <= hf_sm_threshold ) .and. &
               ( ( minval(bc_in%t_soisno_sl) - tfrz ) > soil_tfrz_thresh ) ) then
             hmort = EDPftvarcon_inst%mort_scalar_hydrfailure(cohort_in%pft)
          else
             hmort = 0.0_r8
          end if

In this tag Marcos Longo improved the quadratic solver FATES uses for photosynthesis, the update improves error handling and accommodates edge cases that would had otherwise tripped up the old sover
@glemieux
Copy link
Contributor

Regression testing on derecho is complete. All expected tests are B4B against the latest tag baseline with the exception of one long term test. DIFFs are not unexpected, but I'm going to look into these briefly before next steps.

location: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1130-fates

@glemieux
Copy link
Contributor

This DIFF starts up 2.5 months into the 6 month tests and is occurring only on one gridcell on the coast of Antarctica for that whole time. As such, I think this is good to integrate.

@glemieux glemieux merged commit 0bdb724 into NGEET:main Jan 30, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check Related to internal checks of any type (e.g. variable state) mortality Pertaining to changes to plant mortality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants