Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed argument type declaration for the number of cwd pools in the litter mod #1121

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Nov 17, 2023

Description:

We had been identifying an argument "ncwd" as type(integer), which is kind of strange, probably something I wrote, but most compilers allowed it. Apparently AMD compilers do not like it. @ndkeen identified this and provided a prototype correction, here: E3SM-Project/E3SM#6029 .

Collaborators:

@ndkeen

Expectation of Answer Changes:

none

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

no documentation required

Test Results:

TBD

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux
Copy link
Contributor

Running regression tests on Cheyenne.

@glemieux
Copy link
Contributor

Regression testing on cheyenne is complete and all expected tests pass B4B.

Test results: /glade/u/home/glemieux/scratch/ctsm-tests/tests_pr1121-fates

@glemieux glemieux merged commit 133d57f into NGEET:main Nov 21, 2023
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants