Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:date-picker): quarter selection of date picker #8478

Merged

Conversation

m310851010
Copy link
Contributor

@m310851010 m310851010 commented Apr 4, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7818, #7380, #3124

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@m310851010 m310851010 requested a review from wenqi73 as a code owner April 4, 2024 11:59
Copy link

zorro-bot bot commented Apr 4, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 98.90110% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.60%. Comparing base (d7eff80) to head (f2d3017).
Report is 55 commits behind head on master.

Files Patch % Lines
...ponents/date-picker/lib/quarter-table.component.ts 98.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8478   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         531      535    +4     
  Lines       18398    18427   +29     
  Branches     2813     2817    +4     
=======================================
+ Hits        16853    16880   +27     
  Misses       1228     1228           
- Partials      317      319    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m310851010 m310851010 changed the title feat(module:date-picker): quarter selection of date picker(#7818,#7380) feat(module:date-picker): quarter selection of date picker Apr 4, 2024
@HyperLife1119 HyperLife1119 self-requested a review April 4, 2024 14:33
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyperLife1119
Copy link
Collaborator

@Nicoss54 Can you review this PR together? :)

@Nicoss54
Copy link
Collaborator

@Nicoss54 Can you review this PR together? :)

of course i will review it today or tomorrow morning :)

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there 👋, thank your very much for contributing such fancy feature to ng-zorro, there are some issues should be fixed :)

@m310851010 m310851010 requested a review from Laffery June 1, 2024 13:41
Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 3513889 into NG-ZORRO:master Jun 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants