-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:date-picker): quarter selection of date picker #8478
feat(module:date-picker): quarter selection of date picker #8478
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8478 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 531 535 +4
Lines 18398 18427 +29
Branches 2813 2817 +4
=======================================
+ Hits 16853 16880 +27
Misses 1228 1228
- Partials 317 319 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Nicoss54 Can you review this PR together? :) |
of course i will review it today or tomorrow morning :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there 👋, thank your very much for contributing such fancy feature to ng-zorro, there are some issues should be fixed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7818, #7380, #3124
What is the new behavior?
Does this PR introduce a breaking change?
Other information