-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:modal): expose componentRef nzContent #8389
feat(module:modal): expose componentRef nzContent #8389
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8389 +/- ##
=======================================
Coverage 91.74% 91.75%
=======================================
Files 520 520
Lines 18023 18028 +5
Branches 2838 2838
=======================================
+ Hits 16535 16541 +6
+ Misses 1185 1184 -1
Partials 303 303 ☔ View full report in Codecov by Sentry. |
Can you add Chinese documentation? :D |
I'm sorry i don't speak chinese, but if you can give me the translation i will add it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok, I will translate after the merger is successful. ^o^ |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently modalRef don't expose the componentRef of nzContent which is too restricted. With the new API of Angular, user must have he possibilities to retrieve the ref of the component of nzContent to use for exemple APIs like setInput
Issue Number: N/A
What is the new behavior?
Now ModalRef expose the component Ref of the nzContent when nzContent is a component. This exposition is done by the mehtod getComponentRef which return the ref in a readonly mode
Does this PR introduce a breaking change?
Other information