Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): select max tag count #8371

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

ParsaArvanehPA
Copy link
Contributor

@ParsaArvanehPA ParsaArvanehPA commented Jan 25, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Although nzMaxMultipleCount already exists in the Select component, the visual representation of nz-options when reaching the nzMaxMultipleCount is different from that of Ant Design's.

And since in Ant's documentation, there is a section called Max Count but the same does not exist in Ng-zorro, this section is also added.

What is the new behavior?

explained above.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

Copy link

zorro-bot bot commented Jan 25, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.75%. Comparing base (6024bcc) to head (7588e95).
Report is 28 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8371   +/-   ##
=======================================
  Coverage   91.74%   91.75%           
=======================================
  Files         520      520           
  Lines       18019    18028    +9     
  Branches     2838     2839    +1     
=======================================
+ Hits        16531    16541   +10     
+ Misses       1185     1184    -1     
  Partials      303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Nicoss54 Nicoss54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 18b898e into NG-ZORRO:master Mar 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants