Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): input field length restricted to 82px #7626

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

LemniscateX
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Every input field in <Select/> component cannot extend its length to the rest of line, and that its length is limited to 82px.
Issue Number: #7556

What is the new behavior?

Input field in <Select/> component can stretch to what it should be(with max length equals the max length of the block).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This problem is introduced by fixing #6209 (which is merged in #6222), and the detailed bugtrace can be found in the comment below. 😂 lol

@zorro-bot
Copy link

zorro-bot bot commented Sep 5, 2022

This preview will be available after the AzureCI is passed.

@LemniscateX
Copy link
Contributor Author

CI failed because of a type error in components/core/testing/component-bed.ts, which is in master branch, thus I couldn't decide to fix it myself or wait for remote changes 🧐

@simplejason
Copy link
Member

please make sure npm run test works well in your local env :)

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #7626 (c7fafcd) into master (2cb80fc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   92.02%   92.01%   -0.02%     
==========================================
  Files         502      502              
  Lines       16738    16738              
  Branches     2629     2629              
==========================================
- Hits        15403    15401       -2     
- Misses       1069     1070       +1     
- Partials      266      267       +1     
Impacted Files Coverage Δ
components/select/select-search.component.ts 89.36% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 87.94% <0.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 82159e3 into NG-ZORRO:master Sep 27, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants