-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:select): input field length restricted to 82px #7626
Conversation
Signed-off-by: LemniscateX <[email protected]>
This preview will be available after the AzureCI is passed. |
CI failed because of a type error in |
please make sure |
Codecov Report
@@ Coverage Diff @@
## master #7626 +/- ##
==========================================
- Coverage 92.02% 92.01% -0.02%
==========================================
Files 502 502
Lines 16738 16738
Branches 2629 2629
==========================================
- Hits 15403 15401 -2
- Misses 1069 1070 +1
- Partials 266 267 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
) Signed-off-by: LemniscateX <[email protected]> Signed-off-by: LemniscateX <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Every input field in
<Select/>
component cannot extend its length to the rest of line, and that its length is limited to82px
.Issue Number: #7556
What is the new behavior?
Input field in
<Select/>
component can stretch to what it should be(with max length equals the max length of the block).Does this PR introduce a breaking change?
Other information
This problem is introduced by fixing #6209 (which is merged in #6222), and the detailed bugtrace can be found in the comment below. 😂 lol