Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): do not try to load SVG on the Node.js side since it will throw an error #7290

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented Mar 2, 2022

Issue Number: #7240

@zorro-bot
Copy link

zorro-bot bot commented Mar 2, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #7290 (82bc617) into master (d2e5b76) will decrease coverage by 0.14%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7290      +/-   ##
==========================================
- Coverage   91.76%   91.62%   -0.15%     
==========================================
  Files         487      487              
  Lines       15964    16004      +40     
  Branches     2597     2602       +5     
==========================================
+ Hits        14649    14663      +14     
- Misses       1004     1031      +27     
+ Partials      311      310       -1     
Impacted Files Coverage Δ
components/icon/icon.service.ts 92.64% <50.00%> (-2.81%) ⬇️
components/icon/icon.directive.ts 97.14% <100.00%> (ø)
components/tree/tree-drop-indicator.component.ts 16.66% <0.00%> (-41.67%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0.00%> (-13.05%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
...ts/table/src/table/table-inner-scroll.component.ts 79.41% <0.00%> (-4.42%) ⬇️
components/table/src/table/table.component.ts 91.39% <0.00%> (-1.99%) ⬇️
components/mention/mention-trigger.ts 98.30% <0.00%> (-1.70%) ⬇️
components/core/tree/nz-tree-base.service.ts 83.76% <0.00%> (-1.11%) ⬇️
components/tree/tree-node.component.ts 93.58% <0.00%> (-0.54%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e5b76...82bc617. Read the comment docs.

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit fe0484f into NG-ZORRO:master Mar 3, 2022
@arturovt arturovt deleted the fix/7240 branch March 3, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants