-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:date-picker): fix disable time when date changes #7236
fix(module:date-picker): fix disable time when date changes #7236
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7236 +/- ##
==========================================
- Coverage 91.72% 91.71% -0.02%
==========================================
Files 486 486
Lines 15918 15919 +1
Branches 2588 2588
==========================================
- Hits 14601 14600 -1
- Misses 1004 1008 +4
+ Partials 313 311 -2
Continue to review full report at Codecov.
|
@AdvanceOrange Sorry for the late reply, could you add the unit test about this? See https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/components/date-picker/date-picker.component.spec.ts as a reference. |
Okay. All right. I'll try.
…------------------ 原始邮件 ------------------
发件人: "NG-ZORRO/ng-zorro-antd" ***@***.***>;
发送时间: 2022年2月10日(星期四) 下午5:53
***@***.***>;
***@***.******@***.***>;
主题: Re: [NG-ZORRO/ng-zorro-antd] fix(module:date-picker): fix disable time when date changes (PR #7236)
@AdvanceOrange Sorry for the late reply, could you add the unit test about this? See https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/components/date-picker/date-picker.component.spec.ts as a reference.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@wenqi73 Hi, I've added the unit test code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @AdvanceOrange good job!
close #7069, close #5335
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #7069, #5335
What is the new behavior?
Update the time status when the date changes
Does this PR introduce a breaking change?
Other information