Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix disable time when date changes #7236

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

AdvanceOrange
Copy link
Contributor

@AdvanceOrange AdvanceOrange commented Jan 27, 2022

close #7069, close #5335

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #7069, #5335

What is the new behavior?

Update the time status when the date changes

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 27, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #7236 (424e50c) into master (f40aad9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7236      +/-   ##
==========================================
- Coverage   91.72%   91.71%   -0.02%     
==========================================
  Files         486      486              
  Lines       15918    15919       +1     
  Branches     2588     2588              
==========================================
- Hits        14601    14600       -1     
- Misses       1004     1008       +4     
+ Partials      313      311       -2     
Impacted Files Coverage Δ
...mponents/date-picker/date-range-popup.component.ts 95.16% <100.00%> (+1.10%) ⬆️
components/table/src/table/tr-measure.component.ts 86.36% <0.00%> (-13.64%) ⬇️
components/table/src/table/tbody.component.ts 88.88% <0.00%> (-11.12%) ⬇️
components/table/src/table-style.service.ts 96.55% <0.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40aad9...424e50c. Read the comment docs.

@wenqi73
Copy link
Member

wenqi73 commented Feb 10, 2022

@AdvanceOrange Sorry for the late reply, could you add the unit test about this? See https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/components/date-picker/date-picker.component.spec.ts as a reference.

@AdvanceOrange
Copy link
Contributor Author

AdvanceOrange commented Feb 11, 2022 via email

@AdvanceOrange
Copy link
Contributor Author

@wenqi73 Hi, I've added the unit test code

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @AdvanceOrange good job!

@wenqi73 wenqi73 merged commit ae67952 into NG-ZORRO:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants