Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:select): avoid reflow when select init #6452

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 25, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #6452 (80f53de) into master (4d80873) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6452   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         478      478           
  Lines       15314    15314           
  Branches     2475     2475           
=======================================
+ Hits        13757    13758    +1     
+ Misses        940      939    -1     
  Partials      617      617           
Impacted Files Coverage Δ
components/core/animation/zoom.ts 100.00% <ø> (ø)
components/date-picker/date-picker.component.ts 93.42% <ø> (ø)
components/tree-select/tree-select.component.ts 88.84% <66.66%> (-0.43%) ⬇️
components/select/select.component.ts 87.58% <85.71%> (-0.29%) ⬇️
components/date-picker/picker.component.ts 89.88% <100.00%> (ø)
components/select/select-search.component.ts 87.50% <100.00%> (+0.26%) ⬆️
components/select/select-top-control.component.ts 89.15% <100.00%> (-0.26%) ⬇️
components/time-picker/time-picker.component.ts 86.20% <100.00%> (+0.09%) ⬆️
components/tabs/tab-nav-bar.component.ts 83.09% <0.00%> (+0.70%) ⬆️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d80873...67ec1ae. Read the comment docs.

@hsuanxyz hsuanxyz changed the title fix(module:select): avoid reflow when select init perf(module:select): avoid reflow when select init Feb 26, 2021
@hsuanxyz hsuanxyz merged commit 342d2d1 into NG-ZORRO:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants