Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix broken nzChangeOnSelect #6049

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix(module:cascader): fix broken nzChangeOnSelect #6049

merged 1 commit into from
Nov 16, 2020

Conversation

rppig42
Copy link
Contributor

@rppig42 rppig42 commented Nov 12, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

nzChangeOnSelect is broken

Issue Number: #6048

What is the new behavior?

nzChangeOnSelect works well

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

this bug is introduced by https://github.com/NG-ZORRO/ng-zorro-antd/pull/6023/files .

When clicking a none leaf node, the menu should only disappear when combining nzChangeOnSelect and nzExpandTrigger === 'hover'

@zorro-bot
Copy link

zorro-bot bot commented Nov 12, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #6049 (949b86c) into master (679be27) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6049   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         465      465           
  Lines       14042    14042           
  Branches     2307     2307           
=======================================
+ Hits        12631    12632    +1     
  Misses        863      863           
+ Partials      548      547    -1     
Impacted Files Coverage Δ
components/cascader/cascader.component.ts 94.67% <100.00%> (ø)
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679be27...949b86c. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 1575bae into NG-ZORRO:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants