Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:list): nz-list-item-actions rendered nothing #5465

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

Yukimir
Copy link
Contributor

@Yukimir Yukimir commented Jun 22, 2020

Fix nz-list-item-actions cannot render nz-list-item-action until next VM
turn.

(#5393)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5393

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Fix nz-list-item-actions cannot render nz-list-item-action until next VM
turn.

(NG-ZORRO#5393)
@zorro-bot
Copy link

zorro-bot bot commented Jun 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #5465 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5465   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         453      453           
  Lines       13877    13877           
  Branches     2129     2206   +77     
=======================================
+ Hits        12656    12657    +1     
  Misses        722      722           
+ Partials      499      498    -1     
Impacted Files Coverage Δ
components/list/list-item-cell.ts 89.28% <100.00%> (ø)
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfc443d...2cea90b. Read the comment docs.

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit c126035 into NG-ZORRO:master Jul 1, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
wenqi73 added a commit to wenqi73/ng-zorro-antd that referenced this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants