Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:form): support auto error tips #4888

Merged
merged 1 commit into from
Apr 15, 2020
Merged

feat(module:form): support auto error tips #4888

merged 1 commit into from
Apr 15, 2020

Conversation

danranVm
Copy link
Member

@danranVm danranVm commented Mar 15, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4523

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 15, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #4888 into master will increase coverage by 0.02%.
The diff coverage is 96.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4888      +/-   ##
==========================================
+ Coverage   91.45%   91.48%   +0.02%     
==========================================
  Files         550      550              
  Lines       13694    13739      +45     
  Branches     2107     2122      +15     
==========================================
+ Hits        12524    12569      +45     
  Misses        709      709              
  Partials      461      461              
Impacted Files Coverage Δ
components/core/config/config.ts 100.00% <ø> (ø)
components/form/form-control.component.ts 94.91% <94.59%> (+0.79%) ⬆️
components/form/form.directive.ts 100.00% <100.00%> (ø)
components/grid/col.directive.ts 98.46% <0.00%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f3bda...411ffbf. Read the comment docs.

让提示变得更简单。
需要预先自定义 `Validators` 和提供 `nzTipOptions`,它们优先级如下:

- `Validators` > `nzTipOptions`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nzTipOptions 的名称改成 nzAutoTips 吧,感觉和 nzDisableAutoTips 两个名称关联不上,其他的都ok

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit 0b85483 into NG-ZORRO:master Apr 15, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
@danranVm danranVm deleted the feat-form branch April 18, 2020 14:42
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants