Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:typography): refactor #4819

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #4819 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4819      +/-   ##
==========================================
- Coverage   93.19%   93.18%   -0.02%     
==========================================
  Files         504      504              
  Lines       12731    12731              
  Branches     1959     1959              
==========================================
- Hits        11865    11863       -2     
- Misses        453      454       +1     
- Partials      413      414       +1
Impacted Files Coverage Δ
components/typography/typography.module.ts 100% <ø> (ø)
components/typography/text-edit.component.ts 100% <ø> (ø)
components/typography/text-copy.component.ts 97.14% <ø> (ø)
components/typography/typography.component.ts 97.76% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca02a07...30a0cde. Read the comment docs.

Copy link
Member

@wenqi73 wenqi73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsuanxyz hsuanxyz merged commit 83951c0 into NG-ZORRO:master Mar 2, 2020
@pr-triage pr-triage bot added the PR: merged label Mar 2, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* refactor(module:typography): refactor

* docs: change selectors
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* refactor(module:typography): refactor

* docs: change selectors
@hsuanxyz hsuanxyz deleted the v9/typography branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants