-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern. #4785
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4785 +/- ##
=========================================
- Coverage 93.21% 93.2% -0.01%
=========================================
Files 505 505
Lines 12742 12742
Branches 1955 1955
=========================================
- Hits 11877 11876 -1
Misses 455 455
- Partials 410 411 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@prahaladbelavadi Please change the title of the commit to a more semantic one, to pass CI. |
Hey @wendellhu95 , I changed the title text from Do let me know if this works. Alternatively, do suggest other titles that might work better. Thank you 😄 |
…automatically." to "I will never close automatically."
2d27db0
to
c5fb418
Compare
Hey @wendellhu95 Thanks for correcting me. The commit message should be changed from I could amend it again to include the docs tag or include a reference to the notification title demo if necessary. Thank you |
Hey. You may want to read this section of our contributing guide. |
@wendellhu95 |
Changed text from "I will be close automatically." to "I will never close automatically."
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
The observed pattern for notification content is three repeated sentences.
This PR fixes one instance where the pattern was off.
What is the current behavior?
The notification content currently read:
I will never close automatically. I will be close automatically. I will never close automatically.
What is the new behavior?
The notification content post PR would read:
I will never close automatically. I will never close automatically. I will never close automatically.
Does this PR introduce a breaking change?
Other information