Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern. #4785

Closed
wants to merge 1 commit into from

Conversation

prahaladbelavadi
Copy link
Contributor

Changed text from "I will be close automatically." to "I will never close automatically."

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
The observed pattern for notification content is three repeated sentences.
This PR fixes one instance where the pattern was off.


[*] Refactoring (no functional changes, no api changes)
[*] Application (the showcase website) / infrastructure changes

What is the current behavior?

The notification content currently read:
I will never close automatically. I will be close automatically. I will never close automatically.

What is the new behavior?

The notification content post PR would read:

I will never close automatically. I will never close automatically. I will never close automatically.

Does this PR introduce a breaking change?

[ ] Yes
[*] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 15, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #4785 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4785      +/-   ##
=========================================
- Coverage   93.21%   93.2%   -0.01%     
=========================================
  Files         505     505              
  Lines       12742   12742              
  Branches     1955    1955              
=========================================
- Hits        11877   11876       -1     
  Misses        455     455              
- Partials      410     411       +1
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.31% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760512a...c5fb418. Read the comment docs.

wzhudev
wzhudev previously approved these changes Feb 16, 2020
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev changed the title change notification title text docs: change notification title text in demo Feb 16, 2020
@wzhudev
Copy link
Member

wzhudev commented Feb 16, 2020

@prahaladbelavadi Please change the title of the commit to a more semantic one, to pass CI.

@prahaladbelavadi prahaladbelavadi changed the title docs: change notification title text in demo docs: change notification title text in demo from Changed text from "I will be close automatically." to "I will never close automatically." Feb 17, 2020
@prahaladbelavadi prahaladbelavadi changed the title docs: change notification title text in demo from Changed text from "I will be close automatically." to "I will never close automatically." docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain structure pattern. Feb 17, 2020
@prahaladbelavadi prahaladbelavadi changed the title docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain structure pattern. changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain structure pattern. Feb 17, 2020
@prahaladbelavadi prahaladbelavadi changed the title changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain structure pattern. changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern. Feb 17, 2020
@prahaladbelavadi prahaladbelavadi changed the title changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern. docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern. Feb 17, 2020
@prahaladbelavadi
Copy link
Contributor Author

Hey @wendellhu95 , I changed the title text from
change notification title text docs
to
docs: changed notification title text in demo from "I will be close automatically." to "I will never close automatically." to maintain uniform pattern.

Do let me know if this works.

Alternatively, do suggest other titles that might work better.

Thank you 😄

@wzhudev
Copy link
Member

wzhudev commented Feb 17, 2020

Snipaste_2020-02-17_18-10-52

Sorry if I mislead you. You should probably change the commit title here.

…automatically." to "I will never close automatically."
@prahaladbelavadi
Copy link
Contributor Author

Hey @wendellhu95

Thanks for correcting me.
I amended the commit message and force pushed it.

The commit message should be changed from
change notification title text
to
Changed text from "I will be close automatically. I will never close automatically." to "I will never close automatically."

I could amend it again to include the docs tag or include a reference to the notification title demo if necessary.
Do let me know if this is okay or if any further changes are required.

Thank you

@wzhudev
Copy link
Member

wzhudev commented Feb 18, 2020

Hey. You may want to read this section of our contributing guide.

@prahaladbelavadi
Copy link
Contributor Author

@wendellhu95
The docs have been helpful.
I shall open another PR adhering to the guidelines.
The history for this branch of the fork might be too cluttered.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants