Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:alert): refactor alert #4779

Merged
merged 1 commit into from
Feb 13, 2020
Merged

refactor(module:alert): refactor alert #4779

merged 1 commit into from
Feb 13, 2020

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 13, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #4779 into master will decrease coverage by 0.02%.
The diff coverage is 94.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4779      +/-   ##
==========================================
- Coverage   93.25%   93.23%   -0.03%     
==========================================
  Files         505      505              
  Lines       12734    12736       +2     
  Branches     1957     1955       -2     
==========================================
- Hits        11875    11874       -1     
- Misses        447      451       +4     
+ Partials      412      411       -1
Impacted Files Coverage Δ
components/alert/alert.module.ts 100% <ø> (ø)
components/alert/alert.component.ts 94.23% <94.23%> (ø)
components/card/nz-card.component.ts
components/card/nz-card-grid.directive.ts
components/card/nz-card.module.ts
components/card/nz-card-meta.component.ts
components/card/nz-card-loading.component.ts
components/card/nz-card-tab.component.ts
components/card/card.module.ts 100% <0%> (ø)
components/card/card-meta.component.ts 100% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048902e...e666907. Read the comment docs.

@vthinkxie vthinkxie merged commit 4544e16 into NG-ZORRO:master Feb 13, 2020
@pr-triage pr-triage bot added the PR: merged label Feb 13, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants