Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:mention): refactor #4755

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Feb 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 6, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 6, 2020

Codecov Report

Merging #4755 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4755   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         506      506           
  Lines       12776    12776           
  Branches     2015     2015           
=======================================
  Hits        11914    11914           
  Misses        451      451           
  Partials      411      411
Impacted Files Coverage Δ
components/mention/mention-trigger.ts 100% <ø> (ø)
components/mention/mention.module.ts 100% <ø> (ø)
components/mention/mention.service.ts 90% <ø> (ø)
components/mention/mention-suggestions.ts 100% <ø> (ø)
components/mention/mention.component.ts 98.79% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c4860...d227c95. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 6507203 into NG-ZORRO:master Mar 2, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the v9/mention branch August 5, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants