Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:statistic): refactor #4722

Merged
merged 4 commits into from
Feb 10, 2020
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 24, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #4722 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4722      +/-   ##
==========================================
+ Coverage   93.20%   93.23%   +0.02%     
==========================================
  Files         506      505       -1     
  Lines       12766    12766              
  Branches     1967     1967              
==========================================
+ Hits        11899    11902       +3     
+ Misses        453      452       -1     
+ Partials      414      412       -2     
Impacted Files Coverage Δ
components/time-picker/time-holder.ts 97.31% <0.00%> (+0.67%) ⬆️
components/statistic/countdown.component.ts 94.28% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f3fa2...74bb220. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vthinkxie vthinkxie merged commit b50e9c2 into NG-ZORRO:master Feb 10, 2020
@wzhudev wzhudev deleted the statistic-9.0 branch February 10, 2020 11:09
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* chore(module:statistic): refactor

* test: fix test

* chore: cleanup

* fix: test util import
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* chore(module:statistic): refactor

* test: fix test

* chore: cleanup

* fix: test util import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants