-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(module:statistic): refactor #4722
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4722 +/- ##
==========================================
+ Coverage 93.20% 93.23% +0.02%
==========================================
Files 506 505 -1
Lines 12766 12766
Branches 1967 1967
==========================================
+ Hits 11899 11902 +3
+ Misses 453 452 -1
+ Partials 414 412 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
d3d8951
to
74bb220
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* chore(module:statistic): refactor * test: fix test * chore: cleanup * fix: test util import
* chore(module:statistic): refactor * test: fix test * chore: cleanup * fix: test util import
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information