Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:nz-input): cannot be disabled if ngModel is missing (#4655) #4688

Closed
wants to merge 1 commit into from

Conversation

zhytang
Copy link
Contributor

@zhytang zhytang commented Jan 14, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4655

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 14, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #4688 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4688      +/-   ##
==========================================
+ Coverage   93.17%   93.18%   +<.01%     
==========================================
  Files         507      507              
  Lines       12779    12787       +8     
  Branches     2024     2026       +2     
==========================================
+ Hits        11907    11915       +8     
  Misses        455      455              
  Partials      417      417
Impacted Files Coverage Δ
components/input/nz-input.directive.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa22c0f...4426979. Read the comment docs.

@vthinkxie
Copy link
Member

Hi @zhytang
thanks for your PR, this issue is caused by angular, and fixed by angular v9 now, closing now

@vthinkxie vthinkxie closed this Feb 9, 2020
@zhytang zhytang deleted the add-zhytang branch April 14, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants