refactor: change WithConfig API & add strict property init check #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
|
Pending other issues in milestone 9.0.0 ... |
wzhudev
force-pushed
the
withconfig-refactor
branch
from
1165e00
to
cf2f3d4
Compare
wzhudev
force-pushed
the
withconfig-refactor
branch
from
cf2f3d4
to
975e641
Compare
wzhudev
force-pushed
the
withconfig-refactor
branch
from
975e641
to
d3a6438
Compare
wzhudev
force-pushed
the
withconfig-refactor
branch
from
d3a6438
to
b102a9a
Compare
wzhudev
changed the title
wzhudev
changed the title
wzhudev
force-pushed
the
withconfig-refactor
branch
2 times, most recently
from
eb20675
to
3e714a9
Compare
added 4 commits
April 27, 2020 19:30
chore: merge *nix and windows scripts fix: remove console
to support more strict ts checks fix: fix perperty initialization fix: init fix: fix missing properties fix: fix missing file test: remove test strict checks
wzhudev
force-pushed
the
withconfig-refactor
branch
from
3e714a9
to
10d1740
Compare
|
CI breaks. Try to fix it by creating a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithConfig装饰的对象必须要赋值初始值，不然无法正确工作ViewChildrenContentChildren一律使用!assert 为非空，在 Angular 里QueryList对象总是存在ViewChildContentChild，static: false时使用?标记为可能为空，static: true时标记为!PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information