-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add types definition for input #4575
Conversation
This preview will be available after the TravisCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4575 +/- ##
=========================================
- Coverage 93.33% 93.23% -0.1%
=========================================
Files 504 519 +15
Lines 12772 12822 +50
Branches 2020 2013 -7
=========================================
+ Hits 11921 11955 +34
- Misses 437 452 +15
- Partials 414 415 +1
Continue to review full report at Codecov.
|
fae207b
to
9d961af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hsuanxyz Azure says "build not found". Perheps you could rebase to the lastest master? |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information