Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add types definition for input #4575

Closed
wants to merge 1 commit into from

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 19, 2019

This preview will be available after the TravisCI is passed.

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #4575 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4575     +/-   ##
=========================================
- Coverage   93.33%   93.23%   -0.1%     
=========================================
  Files         504      519     +15     
  Lines       12772    12822     +50     
  Branches     2020     2013      -7     
=========================================
+ Hits        11921    11955     +34     
- Misses        437      452     +15     
- Partials      414      415      +1
Impacted Files Coverage Δ
components/button/nz-button.component.ts 95.12% <ø> (ø)
components/tooltip/nz-tooltip-base.component.ts 92.64% <100%> (ø) ⬆️
components/card/nz-card.component.ts 100% <100%> (ø) ⬆️
components/modal/nz-modal.component.ts 96.19% <100%> (ø) ⬆️
components/popover/nz-popover.directive.ts 100% <100%> (ø) ⬆️
components/tooltip/nz-tooltip-base.directive.ts 95.52% <100%> (ø) ⬆️
components/popconfirm/nz-popconfirm.directive.ts 100% <100%> (ø) ⬆️
components/tooltip/nz-tooltip.directive.ts 100% <100%> (ø) ⬆️
components/empty/nz-empty.service.ts 95.65% <0%> (-4.35%) ⬇️
...otification/nz-notification-container.component.ts 96.87% <0%> (-3.13%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 387ebc1...9d961af. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Feb 3, 2020

@hsuanxyz Azure says "build not found". Perheps you could rebase to the lastest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants