Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module: code-editor): fix wrong initialization with diff mode #4485

Merged
merged 1 commit into from
Nov 29, 2019
Merged

fix(module: code-editor): fix wrong initialization with diff mode #4485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions components/code-editor/nz-code-editor.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,10 +164,7 @@ export class NzCodeEditorComponent implements OnDestroy, AfterViewInit {
private registerResizeChange(): void {
this.ngZone.runOutsideAngular(() => {
fromEvent(window, 'resize')
.pipe(
debounceTime(300),
takeUntil(this.destroy$)
)
.pipe(debounceTime(300), takeUntil(this.destroy$))
.subscribe(() => {
this.layout();
});
Expand Down Expand Up @@ -216,9 +213,10 @@ export class NzCodeEditorComponent implements OnDestroy, AfterViewInit {
} else {
const language = (this.editorOptionCached as EditorOptions).language;
(this.editorInstance as IDiffEditor).setModel({
original: monaco.editor.createModel(this.value, language),
modified: monaco.editor.createModel(this.nzOriginalText, language)
original: monaco.editor.createModel(this.nzOriginalText, language),
modified: monaco.editor.createModel(this.value, language)
});
this.modelSet = true;
}
}
}
Expand Down