feat(module:tabs): add nzCanDeactivate hook #4476

danranVm · 2019-11-26T03:10:51Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4432

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

zorro-bot · 2019-11-26T03:10:55Z

This preview will be available after the checks is complete.

netlify · 2019-11-26T03:24:07Z

Deploy preview for ng-zorro-master ready!

Built with commit b5ba347

https://deploy-preview-4476--ng-zorro-master.netlify.com

danranVm · 2019-11-26T03:25:08Z

@hsuanxyz @vthinkxie @wendzhue
想和你们讨论下子 tab 的 nzCanDeactivate 是否有必要？我写完之后觉得意义不是很大 🤣.
确认后，我再补充文档和测试。

其实我真实的需求挺变态的, 我是需要在子 tab 的 centent ，也就是我的自定义组件 my-cmp1 中去判断能否切换。我暂时想到的办法是给我的每个自定义组件加一个相同的指令，然后通过这个指令拿到自定义组件的实例，然后调用它们的钩子方法。你们还有什么更好的方式吗？

<nz-tabset>
  <nz-tab nzTitle="Tab 1">
   <my-cmp1></my-cmp1>
  </nz-tab>
  <nz-tab nzTitle="Tab 2">
   <my-cmp2></my-cmp2>
  </nz-tab>
  <nz-tab nzTitle="Tab 3">
   <my-cmp3></my-cmp3>
  </nz-tab>
</nz-tabset>

codecov · 2019-11-26T03:30:49Z

Codecov Report

Merging #4476 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4476      +/-   ##
==========================================
+ Coverage   93.23%   93.25%   +0.02%     
==========================================
  Files         519      520       +1     
  Lines       12822    12835      +13     
  Branches     2013     2017       +4     
==========================================
+ Hits        11954    11969      +15     
+ Misses        452      451       -1     
+ Partials      416      415       -1

Impacted Files	Coverage Δ
components/core/util/observable.ts	`100% <100%> (ø)`
components/tabs/nz-tabset.component.ts	`93.42% <100%> (+0.31%)`	⬆️
components/time-picker/time-holder.ts	`97.31% <0%> (+0.67%)`	⬆️
components/typography/nz-typography.component.ts	`99.11% <0%> (+0.88%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6c797...c890baa. Read the comment docs.

hsuanxyz · 2019-11-26T03:57:57Z

@danranVm nzCanChange 可以完成 nzCanDeactivate 的功能。

虽然 router 提供了 CanActivateChild 和 CanDeactivate 钩子，不过我认为是这样的设计是为了父子模块解耦，在 tabs 这个组件上应该不需要这样的设计。

components/tabs/nz-tabset.component.ts

wzhudev · 2019-11-27T02:26:16Z

components/tabs/demo/guard.ts

@@ -1,4 +1,5 @@
 import { ChangeDetectionStrategy, Component } from '@angular/core';
+import { NzCanChangeFn } from 'ng-zorro-antd/tabs';


这个 Type 的名称最好再细化一些，或许其他组件将来也会有这样的需求

@wendzhue 对 API 名有什么更好的建议吗？

@hsuanxyz NzTabsCanChangeFn ? 反正组件 specific 就好了。

那 Input 名呢，要不和 router 对齐一下？比如 nzCanActivateTabs

那就这样吧 ~ @Input() nzCanDeactivate: NzTabsCanDeactivateFn

components/tabs/nz-tabset.component.ts

* feat(module:tabs): add and hooks * feat(module:tabs): fix bug with onpush * feat(module:tabs): remove canDeactivate and add test * feat(module:tabs): update demo * feat(module:tabs): modify api name * feat(module:tabs): remove console close NG-ZORRO#4432

feat(module:tabs): add and hooks

af8ca6d

pr-triage bot added the PR: unreviewed label Nov 26, 2019

auto-assign bot requested a review from vthinkxie November 26, 2019 03:10

auto-assign bot assigned hsuanxyz Nov 26, 2019

feat(module:tabs): fix bug with onpush

68d0de6

hsuanxyz reviewed Nov 26, 2019

View reviewed changes

components/tabs/nz-tabset.component.ts Outdated Show resolved Hide resolved

hsuanxyz reviewed Nov 26, 2019

View reviewed changes

components/tabs/nz-tabset.component.ts Outdated Show resolved Hide resolved

feat(module:tabs): remove canDeactivate and add test

dccc93e

danranVm changed the title ~~feat(module:tabs): add nzCanChange and nzCanDeactivate hooks~~ feat(module:tabs): add nzCanChange hook Nov 27, 2019

feat(module:tabs): update demo

e73e192

wzhudev reviewed Nov 27, 2019

View reviewed changes

hsuanxyz reviewed Nov 27, 2019

View reviewed changes

components/tabs/nz-tabset.component.ts Outdated Show resolved Hide resolved

feat(module:tabs): modify api name

80751bd

danranVm changed the title ~~feat(module:tabs): add nzCanChange hook~~ feat(module:tabs): add nzCanDeactivate hook Nov 27, 2019

danranVm added 3 commits November 27, 2019 23:11

feat(module:tabs): remove console

b5ba347

chore(module:tabs): rebase master

ac75d79

feat(module:tabs): merge master

c890baa

weekly-digest bot mentioned this pull request Dec 29, 2019

Weekly Digest (22 December, 2019 - 29 December, 2019) #4605

Closed

hsuanxyz added the PR: merge-ready label Jan 8, 2020

hsuanxyz approved these changes Jan 8, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jan 8, 2020

hsuanxyz merged commit a533980 into NG-ZORRO:master Jan 8, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jan 8, 2020

danranVm deleted the tabs-guard branch January 11, 2020 05:30

hsuanxyz mentioned this pull request Apr 15, 2020

NG-ZORRO 9.0 #5024

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(module:tabs): add nzCanDeactivate hook #4476

feat(module:tabs): add nzCanDeactivate hook #4476

danranVm commented Nov 26, 2019 •

edited

Loading

zorro-bot bot commented Nov 26, 2019

netlify bot commented Nov 26, 2019 •

edited

Loading

danranVm commented Nov 26, 2019 •

edited

Loading

codecov bot commented Nov 26, 2019 •

edited

Loading

hsuanxyz commented Nov 26, 2019

wzhudev Nov 27, 2019 •

edited

Loading

hsuanxyz Nov 27, 2019

wzhudev Nov 27, 2019

hsuanxyz Nov 27, 2019

danranVm Nov 27, 2019 •

edited

Loading

		@@ -1,4 +1,5 @@
		import { ChangeDetectionStrategy, Component } from '@angular/core';
		import { NzCanChangeFn } from 'ng-zorro-antd/tabs';

feat(module:tabs): add nzCanDeactivate hook #4476

feat(module:tabs): add nzCanDeactivate hook #4476

Conversation

danranVm commented Nov 26, 2019 • edited Loading

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

zorro-bot bot commented Nov 26, 2019

netlify bot commented Nov 26, 2019 • edited Loading

danranVm commented Nov 26, 2019 • edited Loading

codecov bot commented Nov 26, 2019 • edited Loading

Codecov Report

hsuanxyz commented Nov 26, 2019

wzhudev Nov 27, 2019 • edited Loading

Choose a reason for hiding this comment

hsuanxyz Nov 27, 2019

Choose a reason for hiding this comment

wzhudev Nov 27, 2019

Choose a reason for hiding this comment

hsuanxyz Nov 27, 2019

Choose a reason for hiding this comment

danranVm Nov 27, 2019 • edited Loading

Choose a reason for hiding this comment

danranVm commented Nov 26, 2019 •

edited

Loading

netlify bot commented Nov 26, 2019 •

edited

Loading

danranVm commented Nov 26, 2019 •

edited

Loading

codecov bot commented Nov 26, 2019 •

edited

Loading

wzhudev Nov 27, 2019 •

edited

Loading

danranVm Nov 27, 2019 •

edited

Loading