Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:dropdown): fix dropdown contextmenu #3782

Merged
merged 1 commit into from
Jul 13, 2019
Merged

fix(module:dropdown): fix dropdown contextmenu #3782

merged 1 commit into from
Jul 13, 2019

Conversation

vthinkxie
Copy link
Member

close #3768

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jul 13, 2019

Codecov Report

Merging #3782 into master will decrease coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3782      +/-   ##
==========================================
- Coverage   95.39%   95.39%   -0.01%     
==========================================
  Files         712      712              
  Lines       14543    14544       +1     
  Branches     1913     1914       +1     
==========================================
  Hits        13874    13874              
  Misses        243      243              
- Partials      426      427       +1
Impacted Files Coverage Δ
components/dropdown/nz-context-menu.service.ts 95% <83.33%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4926b32...34bc886. Read the comment docs.

@netlify
Copy link

netlify bot commented Jul 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 34bc886

https://deploy-preview-3782--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit cce920d into NG-ZORRO:master Jul 13, 2019
lppedd pushed a commit to lppedd/ng-zorro-antd that referenced this pull request Jul 15, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calling close of NzContextMenuService when no context menu is opened would lead to error
1 participant