Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix reset trigger redraw #3481

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented May 23, 2019

close #3480

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev requested a review from cipchk May 23, 2019 04:42
@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #3481 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3481      +/-   ##
=========================================
+ Coverage    95.6%   95.6%   +<.01%     
=========================================
  Files         609     609              
  Lines       13250   13251       +1     
  Branches     1810    1810              
=========================================
+ Hits        12668   12669       +1     
  Misses        197     197              
  Partials      385     385
Impacted Files Coverage Δ
components/cascader/nz-cascader.service.ts 97.07% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6342657...ed83ecb. Read the comment docs.

@netlify
Copy link

netlify bot commented May 23, 2019

Deploy preview for ng-zorro-master ready!

Built with commit ed83ecb

https://deploy-preview-3481--ng-zorro-master.netlify.com

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenqi73 wenqi73 merged commit 7c0e30c into NG-ZORRO:master Jun 5, 2019
@wzhudev wzhudev deleted the cascader-reset branch June 24, 2019 06:35
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader: 使用 nzLoadData 后无法重置值
4 participants