Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:time-picker): fix nzUse12Hours not binding to empty value #3459

Closed
wants to merge 1 commit into from
Closed

fix(module:time-picker): fix nzUse12Hours not binding to empty value #3459

wants to merge 1 commit into from

Conversation

avin-kavish
Copy link

@avin-kavish avin-kavish commented May 17, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3451

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@avin-kavish avin-kavish marked this pull request as ready for review May 17, 2019 07:07
@avin-kavish
Copy link
Author

There are some more use cases to be tested.

@netlify
Copy link

netlify bot commented May 17, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 3cbc1f7

https://deploy-preview-3459--ng-zorro-master.netlify.com

@avin-kavish avin-kavish reopened this May 17, 2019
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #3459 into master will decrease coverage by 1.17%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
- Coverage   96.66%   95.48%   -1.18%     
==========================================
  Files         609      609              
  Lines       13187    13187              
  Branches     1803     1803              
==========================================
- Hits        12747    12592     -155     
- Misses        199      215      +16     
- Partials      241      380     +139
Impacted Files Coverage Δ
...ents/time-picker/nz-time-picker-panel.component.ts 93.07% <100%> (-3.08%) ⬇️
components/core/util/getMentions.ts 50% <0%> (-16.67%) ⬇️
components/core/scroll/nz-scroll.service.ts 66.03% <0%> (-13.21%) ⬇️
components/core/polyfill/request-animation.ts 20% <0%> (-12%) ⬇️
components/slider/nz-slider-step.component.ts 88.88% <0%> (-11.12%) ⬇️
components/i18n/nz-i18n.service.ts 80.95% <0%> (-9.53%) ⬇️
components/core/util/textarea-caret-position.ts 42.1% <0%> (-8.78%) ⬇️
components/breadcrumb/nz-breadcrumb.component.ts 56.52% <0%> (-6.53%) ⬇️
components/slider/nz-slider-marks.component.ts 90.47% <0%> (-4.77%) ⬇️
components/select/nz-option-container.component.ts 95.34% <0%> (-4.66%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f353c...3cbc1f7. Read the comment docs.

value: Date;
openValue = new Date(0, 0, 0, 0, 0, 0);
use12Hours = false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems unnecessary, NzTest12HourTimePanelComponent already has the test of enabledColumns.

@vthinkxie
Copy link
Member

This Pull Request is going to be closed since no update for a long time, feel free to open a new PR if needed.

@vthinkxie vthinkxie closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants