-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:time-picker): fix nzUse12Hours not binding to empty value #3459
Conversation
There are some more use cases to be tested. |
Deploy preview for ng-zorro-master ready! Built with commit 3cbc1f7 |
Codecov Report
@@ Coverage Diff @@
## master #3459 +/- ##
==========================================
- Coverage 96.66% 95.48% -1.18%
==========================================
Files 609 609
Lines 13187 13187
Branches 1803 1803
==========================================
- Hits 12747 12592 -155
- Misses 199 215 +16
- Partials 241 380 +139
Continue to review full report at Codecov.
|
value: Date; | ||
openValue = new Date(0, 0, 0, 0, 0, 0); | ||
use12Hours = false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems unnecessary, NzTest12HourTimePanelComponent
already has the test of enabledColumns
.
This Pull Request is going to be closed since no update for a long time, feel free to open a new PR if needed. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:
What is the current behavior?
Issue Number: #3451
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Other information