Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:upload): fix deprecated icon class property #3230

Merged
merged 13 commits into from
Apr 17, 2019
Merged

fix(module:upload): fix deprecated icon class property #3230

merged 13 commits into from
Apr 17, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3228

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cipchk and others added 12 commits December 8, 2018 16:41
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Ekko <[email protected]>
Co-authored-by: null <[email protected]>
chore: merge master

Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Wendell <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: GQ <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by: null <[email protected]>
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Freax <[email protected]>
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by: Rasheed Rahman <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
chore: merge master

Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: Ethan Zhao <[email protected]>
Co-authored-by: Wendell <[email protected]>
@netlify
Copy link

netlify bot commented Apr 7, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 836e704

https://deploy-preview-3230--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 7, 2019

Codecov Report

Merging #3230 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   97.37%   97.36%   -0.01%     
==========================================
  Files         559      559              
  Lines       11627    11627              
  Branches      835      835              
==========================================
- Hits        11322    11321       -1     
- Misses        193      194       +1     
  Partials      112      112
Impacted Files Coverage Δ
components/icon/nz-icon.directive.ts 96.96% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0d53...836e704. Read the comment docs.

@vthinkxie vthinkxie merged commit bc4e7da into NG-ZORRO:master Apr 17, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants