Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): support customized modal config (current "autoBod… #2006

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

wilsoncook
Copy link
Member

…yPadding")

close #1720

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1720

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 18, 2018

Codecov Report

Merging #2006 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   96.03%   96.01%   -0.02%     
==========================================
  Files         470      471       +1     
  Lines       11420    11430      +10     
  Branches     1515     1516       +1     
==========================================
+ Hits        10967    10975       +8     
- Misses        130      131       +1     
- Partials      323      324       +1
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 96.27% <100%> (+0.1%) ⬆️
components/modal/nz-modal-config.ts 100% <100%> (ø)
components/tabs/nz-tabset.component.ts 95.72% <0%> (-0.86%) ⬇️
components/table/nz-table.component.ts 95.34% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577ae47...31ac12c. Read the comment docs.

@simplejason simplejason merged commit 1d5e06c into NG-ZORRO:master Sep 7, 2018
hsuanxyz added a commit that referenced this pull request Sep 10, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] modal padding-right
3 participants