Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): trigger keyboard on ios (#1653) #1751

Merged
merged 2 commits into from
Jul 1, 2018
Merged

fix(module:select): trigger keyboard on ios (#1653) #1751

merged 2 commits into from
Jul 1, 2018

Conversation

danielszenasi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Keyboard does't show up on ios

Issue Number: N/A

What is the new behavior?

Keyboard show up on ios

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #1751 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
- Coverage   96.05%   96.05%   -0.01%     
==========================================
  Files         466      466              
  Lines       11146    11144       -2     
  Branches     1456     1455       -1     
==========================================
- Hits        10706    10704       -2     
  Misses        127      127              
  Partials      313      313
Impacted Files Coverage Δ
...mponents/select/nz-select-top-control.component.ts 97.67% <ø> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7a831d...976e7ea. Read the comment docs.

@vthinkxie vthinkxie merged commit 89d05f9 into NG-ZORRO:master Jul 1, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants