Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): return componentRef when nzContent is a component #8339

Merged

Conversation

Nicoss54
Copy link
Collaborator

@Nicoss54 Nicoss54 commented Jan 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

As Angular is constantly evolving, we can do now a lot of things with the componentRef. In this idea in mind, it coud be a good idea to expose the componentRef when the nzContent is a component.

Issue Number: N/A

What is the new behavior?

Now thanks to the getContentComponentRef function expose by the drawerRef. Developer have the possibilities to retrieve the componentRef of the nzContent in a readonly mode

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df766b6) 91.73% compared to head (92612f0) 91.73%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8339   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         520      520           
  Lines       18010    18014    +4     
  Branches     2838     2838           
=======================================
+ Hits        16521    16525    +4     
  Misses       1186     1186           
  Partials      303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicoss54
Copy link
Collaborator Author

Nicoss54 commented Feb 1, 2024

@HyperLife1119 Are you ok to merge this PR ? Then i will do the same for the modal

@HyperLife1119 HyperLife1119 merged commit f71162b into NG-ZORRO:master Feb 1, 2024
9 checks passed
@Nicoss54 Nicoss54 deleted the feature/expose-content-component-ref branch July 31, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants