Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-select: use nzOptions cant show label when label is number #6535

Closed
xiejay97 opened this issue Mar 19, 2021 · 2 comments · Fixed by #6538
Closed

nz-select: use nzOptions cant show label when label is number #6535

xiejay97 opened this issue Mar 19, 2021 · 2 comments · Fixed by #6538

Comments

@xiejay97
Copy link
Contributor

Reproduction link

https://stackblitz.com/edit/angular-bgipsm?file=src/app/app.component.ts

Steps to reproduce

view

What is expected?

show label

What is actually happening?

cant show

Environment Info
ng-zorro-antd 11.2.0
Browser chrome
@xiejay97
Copy link
Contributor Author

nz-option-item use interpolation
image
nzOptions set label by typeof item.label === 'string' ? item.label : null
pass number would be better, which often be use as label

@zorro-bot
Copy link

zorro-bot bot commented Mar 19, 2021

Hello @Xie-jay. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @Xie-jay, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants