Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NzModal footer text is rendering the title #6467

Closed
gsfitis opened this issue Mar 1, 2021 · 0 comments · Fixed by #6468
Closed

NzModal footer text is rendering the title #6467

gsfitis opened this issue Mar 1, 2021 · 0 comments · Fixed by #6468
Assignees

Comments

@gsfitis
Copy link

gsfitis commented Mar 1, 2021

Reproduction link

https://angular-il82cm.stackblitz.io

Steps to reproduce

Add a string to nzFooter property of a simple NzModalComponent.

What is expected?

Judging from the API the modal's nzFooter property accepts a string among other types. So i would expect it to render the passed string.

What is actually happening?

When you pass a string in the nzFooter property it renders the nzTitle property.

Environment Info
ng-zorro-antd 11.2.0
Browser Chrome

I did some digging in the modal source code. I found this

<div *ngIf="!buttonsFooter" [innerHTML]="config.nzTitle"></div>

line in

https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/components/modal/modal-footer.component.ts

line 22.

Is this how it suppose to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants