Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE intellisense for nz-table #4593

Closed
IonelLupu opened this issue Dec 24, 2019 · 1 comment · Fixed by #4608
Closed

IDE intellisense for nz-table #4593

IonelLupu opened this issue Dec 24, 2019 · 1 comment · Fixed by #4608

Comments

@IonelLupu
Copy link

What problem does this feature solve?

the nz-table component doesn't have intellisense when trying to create table rows:

<nz-table #table [nzData]="users">
    <thead>
    <tr>
        <th>Id</th>
        <th>First Name</th>
        <th>Last Name</th>
    </tr>
    </thead>
    <tbody>
    <tr *ngFor="let item of table.data">
        <td>{{item.id}}</td>
        <td>{{item.firstName}}</td>
        <td>{{item.lastName}}</td>
    </tr>
    </tbody>
</nz-table>
import { Component } from '@angular/core';

interface User {
    firstName: string;
    lastName: string;
}

@Component({
    selector: 'app-list',
    templateUrl: './list.component.html',
    styleUrls: ['./list.component.scss']
})
export class ListComponent {
    users: User[] = [];
}

Here, inside ngFor, the 'item' variable is not of type 'User'. It has type 'any' event though 'NzTableComponent' can accept a type T.

nz-table should infer the type of the data from 'nzData'

What does the proposed API look like?

Having intellisense from 'NzTableComponent.data'

@zorro-bot
Copy link

zorro-bot bot commented Dec 24, 2019

Hello @IonelLupu. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @IonelLupu, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!
giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants