Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: code-editor): fix wrong initialization with diff mode #4485

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

simplejason
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

wrong initialization with diff mode

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 29, 2019

This preview will be available after the checks is complete.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #4485 into 8.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              8.x    #4485      +/-   ##
==========================================
- Coverage   92.23%   92.22%   -0.01%     
==========================================
  Files         522      522              
  Lines       11107    11108       +1     
  Branches     2018     2018              
==========================================
  Hits        10244    10244              
- Misses        436      437       +1     
  Partials      427      427
Impacted Files Coverage Δ
components/code-editor/nz-code-editor.component.ts 10.52% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aa68d3...72a2171. Read the comment docs.

@simplejason simplejason merged commit 7ef8c63 into NG-ZORRO:8.x Nov 29, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Dec 9, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Dec 19, 2019
vthinkxie pushed a commit that referenced this pull request Jan 6, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@simplejason simplejason deleted the 8.5.2-hotfix branch November 18, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants