Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): fix tabs still shows when no route is matched #4034

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 21, 2019

close #3873

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

When no route is matched, the tabs component would set nzHideAll to true.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 21, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 23c0adc

https://deploy-preview-4034--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #4034 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4034      +/-   ##
==========================================
+ Coverage   92.38%   92.46%   +0.07%     
==========================================
  Files         506      506              
  Lines       10749    10750       +1     
  Branches     1942     1942              
==========================================
+ Hits         9931     9940       +9     
+ Misses        405      398       -7     
+ Partials      413      412       -1
Impacted Files Coverage Δ
components/tabs/nz-tabset.component.ts 91.73% <100%> (+0.06%) ⬆️
...mponents/dropdown/nz-dropdown-context.component.ts 94.11% <0%> (-5.89%) ⬇️
components/core/util/text-measure.ts 87.61% <0%> (+2.85%) ⬆️
components/select/nz-option-container.component.ts 96.87% <0%> (+3.12%) ⬆️
components/switch/nz-switch.component.ts 97.56% <0%> (+4.87%) ⬆️
components/radio/nz-radio.component.ts 100% <0%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb6972...23c0adc. Read the comment docs.

@ajeiie120120
Copy link

@wendzhue The issue is not totally solved, please check #3873 for more information.

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs - no tab should be active if actual route does not match
3 participants