Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs module router integration does not default to first tab #4067

Closed
lnr0626 opened this issue Aug 27, 2019 · 3 comments
Closed

tabs module router integration does not default to first tab #4067

lnr0626 opened this issue Aug 27, 2019 · 3 comments
Assignees

Comments

@lnr0626
Copy link

lnr0626 commented Aug 27, 2019

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-rg9ml3

Steps to reproduce

You should see the issue when you load the app

What is expected?

The first tab (titled 'Default' in the reproduction) should be active by default

What is actually happening?

No tabs are active, and so no content is shown

Environment Info
ng-zorro-antd 8.2.1
Browser Firefox, Chrome, Safari
@wzhudev
Copy link
Member

wzhudev commented Aug 27, 2019

It's a by-design. #4034

@lnr0626
Copy link
Author

lnr0626 commented Aug 27, 2019

Ah, I didn't find anything about that in the docs (and completely missed it in the patch notes I guess), so assumed it was a regression. I'm surprised something like this was changed in a patch release; but it was pretty quick to work around. Thanks for the quick response.

@vthinkxie
Copy link
Member

vthinkxie commented Aug 27, 2019

Hi @lnr0626
it is a bug fix for us since no tab should active if no router matched
the patch note is here

tabs: fix tabs still shows when no route is matched (#4034) (7ca0a52)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants