Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error occur when press tab to change focus when autocomplete panel not open #2420

Closed
zd5043039119 opened this issue Nov 9, 2018 · 0 comments
Closed

error occur when press tab to change focus when autocomplete panel not open #2420

zd5043039119 opened this issue Nov 9, 2018 · 0 comments
Assignees
@hsuanxyz

Comments

@zd5043039119
Copy link
Contributor

Version

1.8.0

Environment

angular 6.1.6

Reproduction link

https://stackblitz.com/edit/ng-zorro-antd-start-rbyica

Steps to reproduce

foucs on autocomplete input and don't let the selection panel open then click tab to lose focus

What is expected?

don't throw error

What is actually happening?

 ERROR TypeError: Cannot read property 'getLabel' of undefined
    at NzAutocompleteTriggerDirective.handleKeydown (nz-autocomplete-trigger.directive.ts:253)
    at Object.eval [as handleEvent] (VM1102 AppComponent.ngfactory.js:76)
    at handleEvent (view.ts:138)
    at callWithDebugContext (services.ts:639)
    at Object.debugHandleEvent [as handleEvent] (services.ts:375)
    at dispatchEvent (util.ts:134)
    at eval (element.ts:195)
    at HTMLInputElement.eval (dom_renderer.ts:52)
    at ZoneDelegate.invokeTask (zone.js:421)
    at Object.onInvokeTask (ng_zone.ts:262)

Other?
@wzhudev wzhudev self-assigned this Nov 13, 2018
@wzhudev wzhudev assigned hsuanxyz and unassigned wzhudev Nov 22, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 23, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
18445b5 
ref NG-ZORRO#2381, close NG-ZORRO#2420
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 23, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
94fcb35 
ref NG-ZORRO#2381, close NG-ZORRO#2420
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 23, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
83bcc51 
ref NG-ZORRO#2381, close NG-ZORRO#2420
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 26, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
a6f6dd5 
ref NG-ZORRO#2381, close NG-ZORRO#2420
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 26, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
d615ba8 
ref NG-ZORRO#2381, close NG-ZORRO#2420
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Nov 30, 2018
@hsuanxyz
refactor(module:autocomplete): refactor autocomplete
23d98d9 
ref NG-ZORRO#2381, close NG-ZORRO#2420
vthinkxie pushed a commit that referenced this issue Nov 30, 2018
@hsuanxyz @vthinkxie
refactor(module:autocomplete): refactor autocomplete (#2505)
b669751 
ref #2381, close #2420
vthinkxie added a commit that referenced this issue Nov 30, 2018
@vthinkxie
refactor: merge next to master (#2563)
0ff1864 
* docs: update NG-ZORRO logo (#2425)

* fix(module:collapse): can't fold up active panel with accordion (#2440)

close #2437

* chore: update styles(ant-design 3.10.7) (#2432)

* chore: update styles(ant-design 3.10.8) (#2475)

* feat: Adds danish locale (#2486)

close #2485

* fix(module:menu): fix dropdown menu item selected className (#2434)

close #2433

* fix(module:list): fix invalid render empty style when unspecified data source (#2415)

close #2385

* docs(module:modal): add missing nzClassName property (#2400)

* docs: add faq in icons docs (#2459)

* fix(module:menu): fix fold menu (#2454)

close #2449

* refactor(module:all): use cdk keycodes instead of magic number (#2499)

* release(1.8.1): release 1.8.1 (#2523)

* chore: update styles(ant-design 3.10.9) (#2525)

* fix(readme): fix misspelling (#2472)

* refactor(module:all): support Angular 7.0 (#2372)

* refactor(module:all): refactor component to support onPush & SSR

* refactor(module:badge): refactor badge

* refactor(module:button & card): refactor

* test(module:button): fix test case

* fix(module:avatar): fix avatar

* fix(module:tree): fix tree tslint

* fix(module:tree): fix tree module

* fix(module:all): fix tslint config

* refactor(module:all): upgrade to angular 7.0

* fix(module:all): fix typescript error

* fix(module:build): fix build less options

* fix(module:integration): fix webpack test

* build: rm unused package

* build: fix build & ci

* test(module:spin): fix test error

* docs: update readme

*  refactor(module:checkbox): support checkbox onPush (#2478)

* docs: update NG-ZORRO logo (#2425)

* fix(module:collapse): can't fold up active panel with accordion (#2440)

close #2437

* chore: update styles(ant-design 3.10.7) (#2432)

* refactor(module:checkbox): support checkbox onPush

* refactor(module:collapse): support onPush in collapse (#2481)

*  refactor(module:divider): refactor divider (#2482)

ref #2381

* refactor(module:form): refactor form (#2493)

* refactor(module:grid): refactor grid module (#2498)

* refactor(module:layout): refactor layout (#2500)

* feat(module:progress): support custom strokeColor and strokeLinecap (#2404)

close #2378

* feat(module:avatar): support custom size (#2416)

close #2380

* fix(module:timeline): fix loading icon (#2386)

close #2377

* feat(module:drawer): add input property in NzDrawerRef (#2464)

close #2403

* refactor(module:radio): refactor radio to support OnPush (#2519)

* refactor(module:spin): refactor spin (#2530)

* refactor(module:alert & card): refactor card & refactor template outlet (#2532)

* refactor(module:switch & checkbox): refactor switch & checkbox (#2533)

* refactor(module:core): refactor input convert decorators (#2535)

ref #2474

* refactor(module:mention): refactor mention (#2510)

ref: #2381

* refactor(module:steps): refactor steps (#2512)

ref #2381

* feat(module:modal): support clicking ESC to close modal (#2483)

close #1999

* refactor(module:breadcrumb): refactor breadcrumb (#2513)

ref #2381

* refactor(module:skeleton): refactor skeleton (#2514)

ref #2381

* refactor(module:icon): refactor icon (#2517)

ref #2381

* refactor(module:tree-select): refactor tree-select (#2528)

ref: #2381

* build: bump webpack integration (#2524)

build: bump webpack integration

* refactor(module:timeline): refactor timeline (#2515)

close #2379

* support alternate positions, alternate and right alternate
* support reversing

* refactor(module:autocomplete): refactor autocomplete (#2505)

ref #2381, close #2420

* refactor(module:cascader): refactor cascader (#2516)

* refactor(module:cascader): refactor cascader

close #2935
ref #2198

* fix(module:cascader): fix isFocused access

* refactor(module:avatar): refactor avatar (#2536)

* fix(module:avatar): fix text style

* refactor(module:avatar): refactor avatar

ref: #2381

* refactor(module:upload): refactor upload (#2555)

* refactor(module:upload): refactor upload

- feat: add `nzOpenFileDialogOnClick` prop to allow setting whether to open the upload dialog when the component is clicked

* chore: add encapsulation:ViewEncapsulation.None
ref #2381

* refactor(module:list): refactor list (#2548)

* refactor(module:list): refactor list

* fix: import scrolling in share module

* chore: add encapsulation:ViewEncapsulation.None
ref #2381

* refactor(module:transfer): refactor transfer (#2553)

* refactor(module:transfer): refactor transfer

- feat: add nzDisabled property
- need verify design details, ant-design/ant-design#13330

* chore: search muse be disabled

* chore: add encapsulation:ViewEncapsulation.None

ref #2381

* refactor(module:back-top): refactor back-top (#2547)

refactor(module:back-top): refactor back-top

* refactor(module:anchor): refactor anchor (#2546)

* refactor(module:anchor): refactor anchor

- feat: the nzTarget support string value
- fix: invalid id in demo

* chore: add encapsulation:ViewEncapsulation.None

* chore: add encapsulation:ViewEncapsulation.None

* chore: fix display style in host

* chore: remove :host

ref #2381

* refactor(module:affix): refactor affix (#2544)

* refactor(module:affix): refactor affix

- the nzTarget support string value

* fix: release

* style: removed no-any in first line

* fix: fix style

* chore: fix test

* chore: fix display style in host

* chore: remove :host
@hsuanxyz hsuanxyz closed this as completed Dec 4, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz @vthinkxie
refactor(module:autocomplete): refactor autocomplete (NG-ZORRO#2505)
4213c2e 
ref NG-ZORRO#2381, close NG-ZORRO#2420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zd5043039119 @wzhudev @hsuanxyz