Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nz-tree search support case ignore #1996

Closed
Rockergmail opened this issue Aug 16, 2018 · 6 comments
Closed

nz-tree search support case ignore #1996

Rockergmail opened this issue Aug 16, 2018 · 6 comments

Comments

@Rockergmail
Copy link

What problem does this feature solve?

support case ignore when search the nz-tree

What does the proposed API look like?

[caseIgnore]="true"

@wzhudev
Copy link
Member

wzhudev commented Aug 16, 2018

Instead of adding a [caseIgnore] input, adding custom filter is more flexible. @Rockergmail Could you please open a similar issue on Ant Design? To my knowledge they haven't implemented this or [caseIgnore] so far.

@wzhudev wzhudev added the 💬 Discussion Need more insights to this issue label Aug 20, 2018
@Rockergmail
Copy link
Author

@wendzhue yep, adding custom filter is better. The [caseIgnore] was my poor idea.

@wzhudev wzhudev added the Good First Issue Issues recommended for first-time contributor label Aug 20, 2018
@wzhudev
Copy link
Member

wzhudev commented Aug 20, 2018

Hint for fixing this issue:

Custom filter feature is already supported in cascader component, which would be a reference.

@wzhudev wzhudev removed the 💬 Discussion Need more insights to this issue label Oct 2, 2018
@wzhudev wzhudev removed the Good First Issue Issues recommended for first-time contributor label Jan 14, 2019
@krokofant
Copy link
Contributor

krokofant commented Jun 4, 2019

As of now I don't see a upstream issue and the upstream TreeSelect supports things like value for the TreeNode and onSearch method to customize the search. In fact this issue doesn't seem to exist in upstream anymore.

As of now I don't see a upstream issue and the upstream Tree support things like filterTreeNode so that one can apply a custom filter. This does not exist on the NgZorro implementation.

https://ant.design/components/tree/
https://ng.ant.design/components/tree/en

@krokofant
Copy link
Contributor

@Rockergmail This issue isn't fixed. Don't close it.

@krokofant
Copy link
Contributor

Related lines of code

if (value && n.title.includes(value)) {

Ping @oestrogen

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants