Fix/number of interfaces bug #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 10, 2024 00:40
It seems like detecting the number of interfaces a device has is harder than one might think. Apparently those things lie HARD about that. If you then try to allocate memory for the result based on that, but try to write MORE results there, you get a segfault sooner or later. This patch iterates through the answer of the device and just counts them, so this is hopefully the safe way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the computation of number of interfaces of the devices. Sometimes devices seem to report less interfaces than are really visible and
check_interfacesjust allocated memory for the reported number.Execution of
check_interfaceswas unstable in that case, since some writes then occured beyond the borders of allocated memory.This could possibly the reason for #4