add openmpi helper and prepare for release 1.1.0 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfulton
reviewed
Nov 10, 2023
danfulton
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Otherwise pmix changes are greate and LGTM. I would either make the changelog text say "patch release" or we should go to 1.1.0.
Honestly, we've been adding a lot of functionality, so I feel like minor release might be okay, unless we feel we're still not at that level of stability.
lastephey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an openmpi helper module to make using openmpi with slurm pmi2 easier
Note we'll need a corresponding openmpi module MR in the nersc internal ansible config
Updates files for release 1.1.0