Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hook wildcard copy logic #38

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix hook wildcard copy logic #38

merged 1 commit into from
Mar 14, 2023

Conversation

lastephey
Copy link
Collaborator

Addresses #36

Summary- the logic to handle the wildcard copy case where the target path is different than the source path was broken. (It just copied to the source path in the container.) Should hopefully be fixed now.

Other cleanup:

  • renamed some rather cryptic variables to hopefully make this part easier to read and debug
  • no need to delete target path since shutil.copyfile will overwrite filepaths by default

@lastephey lastephey requested review from scanon and danfulton March 14, 2023 06:07
Copy link
Member

@scanon scanon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scanon scanon merged commit 40c181a into main Mar 14, 2023
@danfulton
Copy link
Contributor

Sorry, I'm kinda late to the party here, so maybe I can just make a separate PR. I think we can avoid a little code duplication here as well (although that was also true before Laurie's fixes).

@lastephey
Copy link
Collaborator Author

Ok, actually there is still a logic problem in the bind mount part too, so I'm working on another PR. Maybe hold off until after that?

@danfulton danfulton mentioned this pull request Mar 17, 2023
@scanon scanon deleted the lastephey/fix-copy-logic branch March 17, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants