Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web4 scripts from socialdb #148

Merged
merged 17 commits into from
Sep 11, 2024

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Sep 1, 2024

Preview URL: https://devhubweb4.testnet.page/

Notice that the served index.html is referencing web4browserclient.js with a blockHeight parameter. The block height of the latest deployed web4browserclient.js is obtained to a preload call to socialdb. This ensures that the browser will always load the latest version of the script, and allow local caching as long as there are no changes.

image

The javascript file, which is stored in socialdb, can then be loaded from this URL: https://devhubweb4.testnet.page/resources/devhub.near/web4browserclient.js?blockHeight=127582922

This will query socialdb for the latest block height of the javascript referenced in the web4 deployment, and reference the script in the served index.html. The script will also served through web4. Having the blockheight in the query string when referencing the script, ensure that it's always the latest script being loaded, but also enables caching in the browser as long as there are no changes. This is a good alternative to referencing a CDN where you often don't have the same opportunity to check which version is the latest, and also we can reduce the number of dependencies this way. Both when it comes to referencing the script, as we now only can use the web4 gateway, and also in deployment, where everything can be deployed to socialdb.

Resolves #146

@petersalomonsen
Copy link
Collaborator Author

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Sep 1, 2024

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 5

Your contribution is much appreciated with a final score of 5!
You have received 74 (50 base + 20 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

Another weekly streak completed, well done @petersalomonsen! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

community-factory/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
community/Cargo.toml Outdated Show resolved Hide resolved
discussions/Cargo.toml Outdated Show resolved Hide resolved
@petersalomonsen petersalomonsen marked this pull request as ready for review September 8, 2024 21:20
@petersalomonsen petersalomonsen requested a review from frol September 9, 2024 15:18
dj8yfo pushed a commit to dj8yfo/neardevhub-contract that referenced this pull request Sep 10, 2024
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 5

@frol frol merged commit 093e9d5 into NEAR-DevHub:main Sep 11, 2024
1 check passed
@petersalomonsen petersalomonsen deleted the feat/scripts-from-socialdb branch September 12, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use preloads from socialdb for Web4 frontend scripts
4 participants