Clean URLs on proposal comment links and scroll proposal comment links into view #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since the existing highlight functionality depends on getting accountId and blockheight through props
updated docs on building preview environments
petersalomonsen
changed the title
remove redundant replacing of dev components. make sure that rpc and near social api returns the same blog content
petersalomonsen
requested review from
Megha-Dev-19 and
Tguntenaar
as code owners
|
@Megha-Dev-19 @Tguntenaar See the updated docs on deploying preview environments, and also the fixes/improvements on the blog tests |
Megha-Dev-19
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Looks great @petersalomonsen, thank you for updating the build script.
frol
pushed a commit
to NEAR-DevHub/neardevhub-contract
that referenced
this pull request
Jul 19, 2024
Enables "scroll into view" for proposal comments functionality for NEAR-DevHub/neardevhub-bos#868 Example link to comment being scrolled into view: https://devhublink.testnet.page/proposal/127?accountId=theori.near&blockHeight=121684702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of clean URL scrolling into the view:
https://devhublink.testnet.page/proposal/127?accountId=theori.near&blockHeight=121684702
Note that the usual practice would be to have
accountIdandblockHeightafter a hash#and not the question mark?, but since the highlighting functionality depends on reading this values, they have to be in the query string (?).Clicking the share button will now also copy the same URL to the clipboard.
The scrolling into view functionality depends on the web4 deployment and this PR in the contract: NEAR-DevHub/neardevhub-contract#142
Also updated documentation about deploying preview environments, since we need to combine bos cli (for deployment ) with bos-workspace build ( for applying replacements etc ).
Fixes #867