Fix hydration error on access denied error pages #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have helper methods on the class.
This was fixed by using responseContext to determine whether or not to render an `AccessDeniedError`. This feels fairly fragile, but not sure how it can be improved as long as errors aren't passed with the graphql cache from server to client.
Previously this would render differently on client and server due to the if check only triggering if the `redirectContext` was present.
jnatten
force-pushed
the
ssr-error-pages
branch
from
8c3b975 to
9ecad53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fikser hydreringsfeil på resourcepage dersom vi finner en tilgangsfeil.
"Problemet" er at apollo ikke tar med feil i cachen sin så alle feil vil bare rendres på server dersom vi baserer oss på
errorobjektet i queryen.Denne PR'en fikser det ved å sende feil fra server til klient (og å hente det ut i
useGraphQuerygjennom en context.Eksempel hvis en læringssti er privat: http://localhost:3000/subject:20/topic:1:194565/resource:1:179189
Eksempel på en 410: http://localhost:3000/nb/article/9645