Use new Input component #1912
Merged
Use new Input component #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinewi
commented
Jul 11, 2024
katrinewi
commented
Jul 11, 2024
katrinewi
force-pushed
the
new-input-components
branch
from
6ebc693
to
5834933
Compare
katrinewi
force-pushed
the
new-input-components
branch
from
5834933
to
86c6ac5
Compare
|
Du har glemt et TextArea i |
Jonas-C
reviewed
Jul 12, 2024
| )} | ||
| /> | ||
| <Controller | ||
| control={control} | ||
| name={"parentCategoryId"} | ||
| rules={{ required: false }} | ||
| render={({ field, fieldState }) => ( | ||
| <FormControl id="parentCategoryId" isInvalid={!!fieldState.error?.message}> | ||
| <StyledLabel textStyle="label-small">{t("myNdla.arena.admin.category.form.parentCategoryId")}</StyledLabel> | ||
| <FieldRoot invalid={!!fieldState.error?.message}> |
There was a problem hiding this comment.
Her brekker du koblingen mellom label og select. Du kan wrappe Select med en <Field.Select asChild>. Vi eksporterer den ikke, men ark har den!
There was a problem hiding this comment.
Var ikke meningen å ta med de endringene egentlig 😅 revertert nå!
katrinewi
force-pushed
the
new-input-components
branch
from
b7a6a91
to
04d5d58
Compare
Jonas-C
reviewed
Jul 12, 2024
src/containers/MyNdla/Arena/components/FlagPostModalContent.tsx
Outdated
Show resolved
Hide resolved
katrinewi
force-pushed
the
new-input-components
branch
from
04d5d58
to
6e7fa88
Compare
Jonas-C
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.