Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Safelink components + package bump #1910

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Updated Safelink components + package bump #1910

merged 8 commits into from
Jul 11, 2024

Conversation

katrinewi
Copy link
Contributor

@katrinewi katrinewi commented Jul 10, 2024

  • Bumper pakker
  • Oppdaterer Image import til å være fra primitives
  • Refakturerer Safelink komponenter

NB: FolderResource er en del av det gamle delt mappe designet, så jeg har ikke gjort noe for at det skal se fint ut

@katrinewi katrinewi marked this pull request as ready for review July 10, 2024 15:08
@katrinewi katrinewi requested a review from a team July 10, 2024 15:13
src/components/CompetenceGoalTab.tsx Outdated Show resolved Hide resolved
to={routes.myNdla.root}
aria-label={t("myNdla.myNDLA")}
>
<StyledLink variant="tertiary" to={routes.myNdla.root} aria-label={t("myNdla.myNDLA")}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sjekker du også at ting trenger å være stylet, eller tenker du at vi tar det senere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg har egentlig prøvd å rydde opp i det og, men har nok glemt noen steder, som her 😅

@katrinewi katrinewi requested a review from Jonas-C July 11, 2024 07:00
@katrinewi katrinewi merged commit b6f4846 into master Jul 11, 2024
6 checks passed
@katrinewi katrinewi deleted the new-safelink branch July 11, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants