Integrate panda #1902
Merged
Integrate panda #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jonas-C
force-pushed
the
integrate-panda
branch
2 times, most recently
from
6233985
to
73f467c
Compare
MaPoKen
approved these changes
Jul 8, 2024
|
|
||
| const MastheadSearch = ({ subject }: Props) => { | ||
| const [isOpen, setIsOpen] = useState(false); | ||
| const [dialogState, setDialogState] = useState({ open: false }); |
There was a problem hiding this comment.
Om root trenger et objekt for onOpenChange kan vi typesette dette på en måte? Så vi vet hva som kan være i dialogState?
There was a problem hiding this comment.
Ark eksporterer typer for det, men lurer på om vi skal vente litt med det. Litt usikker på hva konvensjonen for state skal være med de nye komponentene inntil videre :')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tar såvidt inn litt komponenter. Ser jo selvfølgelig ikke helt fantastisk ut. Vi må uansett starte et eller annet sted :')