Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate storybook package #77

Merged
merged 14 commits into from
Aug 8, 2017
13 changes: 2 additions & 11 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,6 @@
module.exports = {
extends: "ndla",
plugins: ["prettier"],
extends: 'ndla',
rules: {
"import/no-extraneous-dependencies": 0, // Should be enabled when https://github.com/benmosher/eslint-plugin-import/issues/458 is closed
"prettier/prettier": [
"error",
{
jsxBracketSameLine: true,
singleQuote: true,
trailingComma: "all"
}
]
'import/no-extraneous-dependencies': 0, // Should be enabled when https://github.com/benmosher/eslint-plugin-import/issues/458 is closed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Denne issuen er blitt stengt nå: import-js/eslint-plugin-import#458

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jepp, har sett det. Tenker å ta en eslint "maintenance" runde snart.

},
};
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '6'
- '8'
script:
- yarn lint
- yarn test
Expand Down
38 changes: 20 additions & 18 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"name": "frontend-packages",
"description": "NDLA Frontend Packages",
"scripts": {
"lint": "eslint --ext .js --ext .jsx ./packages --ignore-path .gitignore",
"lint": "yarn run lint-prettier --silent && eslint --ext .js --ext .jsx ./packages --ignore-path .gitignore",
"lint-prettier": "node scripts/prettier.js lint",
"test": "cross-env NODE_ENV=unittest jest",
"postinstall": "lerna bootstrap",
"deploy-storybook": "storybook-to-ghpages",
Expand All @@ -13,7 +14,7 @@
"start": "concurrently --kill-others \"npm run watch\" \"npm run start-storybook\"",
"start-storybook": "node ./scripts/startStorybook.js",
"build-storybook": "node ./scripts/buildStorybook.js",
"prettier": "node prettier.js write"
"prettier": "node ./scripts/prettier.js write"
},
"repository": {
"type": "git",
Expand All @@ -28,36 +29,37 @@
"devDependencies": {
"@kadira/storybook-deployer": "1.2.0",
"babel-cli": "6.24.1",
"babel-core": "6.24.1",
"babel-core": "^6.25.0",
"babel-jest": "20.0.3",
"babel-plugin-transform-object-rest-spread": "6.23.0",
"babel-preset-env": "^1.4.0",
"babel-preset-env": "^1.6.0",
"babel-preset-es2015": "6.24.1",
"babel-preset-react": "6.24.1",
"chalk": "1.1.3",
"chalk": "^2.1.0",
"chokidar": "1.7.0",
"classnames": "2.2.5",
"concurrently": "3.4.0",
"cross-env": "5.0.0",
"concurrently": "^3.5.0",
"cross-env": "^5.0.4",
"css-loader": "0.28.4",
"eslint": "3.19.0",
"eslint-config-ndla": "^0.2.1",
"eslint-plugin-prettier": "^2.1.2",
"jest": "20.0.4",
"lerna": "2.0.0-rc.5",
"lerna": "^2.0.0",
"node-sass": "^4.3.0",
"prettier": "^1.5.2",
"prop-types": "15.5.10",
"react": "15.5.4",
"react": "^15.6.1",
"react-bem-helper": "1.4.1",
"react-collapse": "4.0.2",
"react-dom": "15.5.4",
"react-collapse": "^4.0.3",
"react-dom": "^15.6.1",
"react-height": "3.0.0",
"react-motion": "0.5.0",
"react-router-dom": "^4.1.1",
"react-router-dom": "^4.1.2",
"react-tabs": "1.1.0",
"react-test-renderer": "15.5.4",
"rimraf": "2.6.1"
},
"dependencies": {
"html-react-parser": "^0.3.4"
"react-test-renderer": "^15.6.1",
"rimraf": "2.6.1",
"sass-loader": "^6.0.6",
"style-loader": "^0.18.2",
"webpack": "^3.4.1"
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { configure } from '@storybook/react';
import { setOptions } from '@storybook/addon-options';
import '../src/main.scss';
import '../src/editor.scss';
import '../src/audioSearch.scss';
import '../src/imageSearch.scss';
import '../src/videoSearch.scss';
import '../../ndla-ui/src/main.scss';
import '../../ndla-ui/src/editor.scss';
import '../../ndla-ui/src/audioSearch.scss';
import '../../ndla-ui/src/imageSearch.scss';
import '../../ndla-ui/src/videoSearch.scss';

setOptions({
name: 'NDLA Designmanual',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module.exports = {
{
test: /.scss$/,
loaders: ['style-loader', 'css-loader', 'sass-loader'],
include: path.resolve(__dirname, '../src/'),
include: path.resolve(__dirname, '../../ndla-ui/src/'),
},
],
},
Expand Down
13 changes: 13 additions & 0 deletions packages/designmanual/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Designmanual

Designmanual/Styleguide for NDLA.

## Getting started

```sh
$ yarn start
```

```sh
$ npm start
```
52 changes: 52 additions & 0 deletions packages/designmanual/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
{
"private": true,
"name": "designmanual",
"version": "1.0.0",
"description": "Styleguide and ui component library for NDLA.",
"license": "GPL-3.0",
"main": "lib/index.js",
"module": "es/index.js",
"jsnext:main": "es/index.js",
"scripts": {
"start": "npm run storybook",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook -c .storybook -o ../../.out"
},
"repository": {
"type": "git",
"url": "https://github.com/NDLANO/frontend-packages.git/ndla-ui/"
},
"author": "[email protected]",
"peerDependencies": {
"prop-types": "^15.5.8",
"react": "^15.5.4"
},
"devDependencies": {
"@storybook/addon-actions": "3.0.0",
"@storybook/addon-links": "3.0.0",
"@storybook/addon-options": "3.0.0",
"@storybook/react": "3.0.0",
"classnames": "2.2.5",
"react-bem-helper": "1.4.1",
"react-prop-types": "0.4.0",
"react-sticky-header": "^0.1.6",
"btoa": "^1.1.2",
"decorate-component-with-props": "^1.0.2",
"draft-convert": "1.4.3",
"draft-js": "0.10.0",
"extract-text-webpack-plugin": "2.1.0",
"inuitcss": "^6.0.0-beta.4",
"isomorphic-fetch": "^2.2.1",
"moment": "^2.17.1",
"ndla-article-scripts": "^0.0.7",
"ndla-audio-search": "^0.1.1-0",
"ndla-editor": "^0.1.6",
"ndla-image-search": "^0.1.6",
"ndla-licenses": "^0.0.9",
"ndla-tabs": "^0.3.3",
"ndla-util": "^0.1.4",
"ndla-ui": "^0.7.6",
"ndla-video-search": "^0.1.6",
"react-helmet": "5.1.3"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import React from 'react';
import PropTypes from 'prop-types';
import BEMHelper from 'react-bem-helper';
import moment from 'moment';
import { User, Time } from '../../src/icons';
import { User, Time } from 'ndla-ui/icons';
import LicenseExample from './LicenseExample';

const classes = new BEMHelper({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import React from 'react';
import PropTypes from 'prop-types';

import { Article, OneColumn, LayoutItem } from '../../src';
import { Article, OneColumn, LayoutItem } from 'ndla-ui';
import ArticleByline from './ArticleByline';
import LicenseExample from './LicenseExample';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import React, { Component } from 'react';
import PropTypes from 'prop-types';
import Helmet from 'react-helmet';
import { Button } from 'ndla-ui';
import { fetchArticle } from './articleApi';
import SimpleSubmitForm from './SimpleSubmitForm';
import { Button } from '../../src/';
import ArticleExample from './ArticleExample';

class ArticleLoader extends Component {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
addShowFigureDetailsClickListeners,
} from 'ndla-article-scripts';

import { Figure, FigureCaption, FigureDetails } from '../../src';
import { Figure, FigureCaption, FigureDetails } from 'ndla-ui';

const caption = `I værmeldingene til NRK på 1980-tallet var symbolet for strålende
solskinn en hvit sirkel. Ved skiftende vær var sirkelen delt i to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
MediaListItemActions,
MediaListItemImage,
MediaListItemMeta,
} from '../../src';
} from 'ndla-ui';

const VideoContent = () =>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,19 @@
*/

import React from 'react';
import PropTypes from 'prop-types';
import Tabs from 'ndla-tabs';
import { getLicenseByAbbreviation } from 'ndla-licenses';
import { LicenseShape } from '../../src/shapes';

import { Icon, Button, LicenseByline } from '../../src';
import { Icon, Button, LicenseByline } from 'ndla-ui';

const LicenseShape = PropTypes.shape({
short: PropTypes.string.isRequired,
title: PropTypes.string.isRequired,
userFriendlyTitle: PropTypes.string.isRequired,
description: PropTypes.string.isRequired,
rights: PropTypes.arrayOf(PropTypes.string).isRequired,
});

const VideoContent = () =>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,19 @@
*/

import React from 'react';
import PropTypes from 'prop-types';
import Tabs from 'ndla-tabs';
import { getLicenseByAbbreviation } from 'ndla-licenses';
import { LicenseShape } from '../../src/shapes';

import { Icon, Button, LicenseByline } from '../../src';
import { Icon, Button, LicenseByline } from 'ndla-ui';

const LicenseShape = PropTypes.shape({
short: PropTypes.string.isRequired,
title: PropTypes.string.isRequired,
userFriendlyTitle: PropTypes.string.isRequired,
description: PropTypes.string.isRequired,
rights: PropTypes.arrayOf(PropTypes.string).isRequired,
});

const VideoContent = () =>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import React from 'react';
import { getLicenseByAbbreviation } from 'ndla-licenses';

import { Copy, Download } from '../../src/icons';
import { Copy, Download } from 'ndla-ui/icons';

import { LicenseByline } from '../../src';
import { LicenseByline } from 'ndla-ui';

const LicenseExampleImage = () =>
<div className="u-expanded">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
import React from 'react';
import { getLicenseByAbbreviation } from 'ndla-licenses';

import { Copy, Download } from '../../src/icons';
import { Copy, Download } from 'ndla-ui/icons';

import { LicenseByline } from '../../src';
import { LicenseByline } from 'ndla-ui';

const LicenseExampleImageAlt = () =>
<div className="u-expanded">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import React from 'react';
import { getLicenseByAbbreviation } from 'ndla-licenses';

import { LicenseByline } from '../../src';
import { LicenseByline } from 'ndla-ui';

const LicenseExampleImage = () =>
<div className="license u-expanded">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { Button } from '../../src';
import { Button } from 'ndla-ui';

class SimpleSubmitForm extends Component {
constructor(props) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import React from 'react';
import { storiesOf } from '@storybook/react';
import { Table, LayoutItem } from 'ndla-ui';
import { Center } from './helpers';
import article from '../dummydata/index';
import { Table, LayoutItem } from '../src';

const heading = (articleHTML, level) => {
if (!articleHTML) return `<h${level}>Overskrift ${level}</h${level}>`;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@ import React from 'react';

import { storiesOf } from '@storybook/react';
import { BY, NC, ND } from 'ndla-licenses';

import { Center } from './helpers';
import {
Glossary,
Button,
FilterList,
Pager,
Expand All @@ -18,9 +17,10 @@ import {
OneColumn,
LayoutItem,
RelatedArticles,
} from '../src';
import { Time, User } from '../src/icons';
import Glossary from './../src/glossary/Glossary';
} from 'ndla-ui';
import { Time, User } from 'ndla-ui/icons';

import { Center } from './helpers';
import FigureWithLicense from './article/FigureWithLicense';
import articles, {
topicList,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';

import { storiesOf } from '@storybook/react';
import { LayoutItem } from '../src';
import { LayoutItem } from 'ndla-ui';
import { Center } from './helpers';

storiesOf('Konsepter', module).add('Navngivning av innholdselementer', () =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ import PropTypes from 'prop-types';
import { convertFromHTML } from 'draft-convert';
import { Entity, EditorState } from 'draft-js';
import NDLAEditor, { withStateHandler } from 'ndla-editor';
import { Button } from 'ndla-ui';
import { fetchArticleFromApi, fetchWithToken } from '../article/articleApi';
import SimpleSubmitForm from '../article/SimpleSubmitForm';
import { Button } from '../../src/';

const StatefulNDLAEditor = withStateHandler(NDLAEditor);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import React from 'react';

import { TopicBreadcrumb } from '../../src';
import { TopicBreadcrumb } from 'ndla-ui';
import { topicList, subjectList } from '../../dummydata/index';

export const TopicBreadcrumbDefault = () =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
ClickToggle,
TopicMenu,
TopicBreadcrumb,
} from '../../src';
} from 'ndla-ui';
import { topicMenu, subjectList, topicList } from '../../dummydata';

export const MastheadLeftRight = () =>
Expand Down
Loading