-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate storybook package #77
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
34b31be
Create separate prive storybook package and move files
oyvinmar 7b795db
Fix scripts
oyvinmar 4e3799b
move common dependencies to root
oyvinmar 04b7cdc
Bump lerna
oyvinmar d123d8c
Fix lint errors
oyvinmar 6a00953
Rename sorybook package to designmanual
oyvinmar 18bfb10
Fix prettier script
oyvinmar b9b2eca
Bump nodejs version in ci
oyvinmar 7a1343b
Add missing yarn lock files
oyvinmar 2d8e222
Move prettier script
oyvinmar 1afe323
Fix vscode settings
oyvinmar c1dc304
Update README
oyvinmar 222fc4f
Fix editor style import
oyvinmar 1124021
Bump root dependencies
oyvinmar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,6 @@ | ||
module.exports = { | ||
extends: "ndla", | ||
plugins: ["prettier"], | ||
extends: 'ndla', | ||
rules: { | ||
"import/no-extraneous-dependencies": 0, // Should be enabled when https://github.com/benmosher/eslint-plugin-import/issues/458 is closed | ||
"prettier/prettier": [ | ||
"error", | ||
{ | ||
jsxBracketSameLine: true, | ||
singleQuote: true, | ||
trailingComma: "all" | ||
} | ||
] | ||
'import/no-extraneous-dependencies': 0, // Should be enabled when https://github.com/benmosher/eslint-plugin-import/issues/458 is closed | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
language: node_js | ||
node_js: | ||
- '6' | ||
- '8' | ||
script: | ||
- yarn lint | ||
- yarn test | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
10 changes: 5 additions & 5 deletions
10
packages/ndla-ui/.storybook/config.js → packages/designmanual/.storybook/config.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Designmanual | ||
|
||
Designmanual/Styleguide for NDLA. | ||
|
||
## Getting started | ||
|
||
```sh | ||
$ yarn start | ||
``` | ||
|
||
```sh | ||
$ npm start | ||
``` |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"private": true, | ||
"name": "designmanual", | ||
"version": "1.0.0", | ||
"description": "Styleguide and ui component library for NDLA.", | ||
"license": "GPL-3.0", | ||
"main": "lib/index.js", | ||
"module": "es/index.js", | ||
"jsnext:main": "es/index.js", | ||
"scripts": { | ||
"start": "npm run storybook", | ||
"storybook": "start-storybook -p 6006", | ||
"build-storybook": "build-storybook -c .storybook -o ../../.out" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/NDLANO/frontend-packages.git/ndla-ui/" | ||
}, | ||
"author": "[email protected]", | ||
"peerDependencies": { | ||
"prop-types": "^15.5.8", | ||
"react": "^15.5.4" | ||
}, | ||
"devDependencies": { | ||
"@storybook/addon-actions": "3.0.0", | ||
"@storybook/addon-links": "3.0.0", | ||
"@storybook/addon-options": "3.0.0", | ||
"@storybook/react": "3.0.0", | ||
"classnames": "2.2.5", | ||
"react-bem-helper": "1.4.1", | ||
"react-prop-types": "0.4.0", | ||
"react-sticky-header": "^0.1.6", | ||
"btoa": "^1.1.2", | ||
"decorate-component-with-props": "^1.0.2", | ||
"draft-convert": "1.4.3", | ||
"draft-js": "0.10.0", | ||
"extract-text-webpack-plugin": "2.1.0", | ||
"inuitcss": "^6.0.0-beta.4", | ||
"isomorphic-fetch": "^2.2.1", | ||
"moment": "^2.17.1", | ||
"ndla-article-scripts": "^0.0.7", | ||
"ndla-audio-search": "^0.1.1-0", | ||
"ndla-editor": "^0.1.6", | ||
"ndla-image-search": "^0.1.6", | ||
"ndla-licenses": "^0.0.9", | ||
"ndla-tabs": "^0.3.3", | ||
"ndla-util": "^0.1.4", | ||
"ndla-ui": "^0.7.6", | ||
"ndla-video-search": "^0.1.6", | ||
"react-helmet": "5.1.3" | ||
} | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
packages/ndla-ui/stories/basic-styles.jsx → ...ges/designmanual/stories/basic-styles.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/ndla-ui/stories/concepts.js → packages/designmanual/stories/concepts.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Denne issuen er blitt stengt nå: import-js/eslint-plugin-import#458
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jepp, har sett det. Tenker å ta en eslint "maintenance" runde snart.