refactor: Use Combobox in AddExistingResource #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
reviewed
Nov 4, 2024
Jonas-C
force-pushed
the
refactor/combobox-in-add-existing-resource
branch
from
162a4a3
to
5234533
Compare
|
Det er ikke mulig å fjerne valgt artikkel ved å klikke i combobox :/ |
katrinewi
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERK: Det er forskjeller på fetching av læringsstier her og i gammel implementasjon. Tenkte en åpenbar forenkling var å kun bruke søk uavhengig av om vi skulle hente ut læringsstier eller "vanlige" artikler. En sjapp sjekk med API'et viser dog at vi returnerer et ulikt antall ressurser på tvers av de to API'ene.
CREATED_BY_NDLAer heller ikke mulig å bruke fra søke-API'et, men den brukes vel ikke i søket i ndla-frontend heller?