Refactor h5p and remove h5p when no item selected #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinewi
reviewed
Nov 4, 2024
Comment on lines
37
to
39
| outline: "2px solid", | ||
| _selected: { | ||
| "& > figure": { | ||
| outline: "2px solid", | ||
| outlineColor: "brand.primary", | ||
| }, | ||
| outlineColor: "stroke.default", |
There was a problem hiding this comment.
Tror outline må flyttes inn i _selected for at dette skal fungere?
There was a problem hiding this comment.
fikse opp i dette? indikering av selection fungerer fortsatt ikke :/
MaPoKen
force-pushed
the
refactor/slateh5p-to-dialog
branch
from
fd802f6
to
bd3ed64
Compare
MaPoKen
force-pushed
the
refactor/slateh5p-to-dialog
branch
from
bd3ed64
to
7c64325
Compare
katrinewi
reviewed
Nov 5, 2024
katrinewi
reviewed
Nov 5, 2024
katrinewi
approved these changes
Nov 5, 2024
MaPoKen
force-pushed
the
refactor/slateh5p-to-dialog
branch
from
587cffb
to
4a25881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new components h5p. Fix bug where h5p isn't removed on onClose without selecting